As Mozilla, we want users who set Firefox for Android as the default browser to also use Firefox when 3rd party apps use custom tabs

This is not controlled by us. However this should be the default behavior when the custom tabs support library (for third-party apps) is used.

Comment on attachment 8856432 [details] Bug 1329152 - Enable custom tabs by default https://reviewboard.mozilla.org/r/128384/#review131966 Technically this patch is okay. But there are two things that prevent me from r+ing: * There are still open bugs linked to the MVP bug. Is this really ready? Has this been tested thoroughly by QA and do they recommend releasing? * Please think about moving this feature behind a switchboard flag. This will allow a staged rollout and we will be able to pull this feature if we see problems. In fact that's something we should consider for all new features - especially with Aurora going away. In this case we might not be able to do this for the manifest entries - but we could keep the routing in LauncherActivity: If enabled (via switchboard) open custom tab, otherwise open browser.

(In reply to Sebastian Kaspari (:sebastian) from comment #4) > Comment on attachment 8856432 [details] > Bug 1329152 - Enable custom tabs by default > > https://reviewboard.mozilla.org/r/128384/#review131966 > > Technically this patch is okay. But there are two things that prevent me > from r+ing: > > * There are still open bugs linked to the MVP bug. Is this really ready? Has > this been tested thoroughly by QA and do they recommend releasing? Per today's meeting we want to enable this then get more feedback(...bugs) as early as possible. Do you think this make sense? > * Please think about moving this feature behind a switchboard flag. This > will allow a staged rollout and we will be able to pull this feature if we > see problems. In fact that's something we should consider for all new > features - especially with Aurora going away. In this case we might not be > able to do this for the manifest entries - but we could keep the routing in > LauncherActivity: If enabled (via switchboard) open custom tab, otherwise > open browser. OK! I will prepare a new patch which involve Switchboard then we have ability to disable this. (just prepare the patch for technically reviewing, I won't land it until I get green light)

For now the patches are for technical review.

Comment on attachment 8856432 [details] Bug 1329152 - Enable custom tabs by default https://reviewboard.mozilla.org/r/128384/#review138412

Comment on attachment 8861872 [details] Bug 1329152 - turn on CustomTabs via SwitchBoard https://reviewboard.mozilla.org/r/133892/#review138414 Please reverse this: The experiment should control whether a feature is enabled. I added a new experiment called "custom-tabs" to the production configuration. This experiment is enabled for Nightly/Aurora and local builds already: https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records

This is the last piece of P1 for custom tab.

(In reply to Sebastian Kaspari (:sebastian) from comment #10) > Comment on attachment 8861872 [details] > Bug 1329152 - be able to turn off CustomTabs via SwitchBoard > > https://reviewboard.mozilla.org/r/133892/#review138414 > > Please reverse this: The experiment should control whether a feature is > enabled. OK! I reversed the statement. Now it enable CustomTabs via SwitchBoard.

Comment on attachment 8861872 [details] Bug 1329152 - turn on CustomTabs via SwitchBoard https://reviewboard.mozilla.org/r/133892/#review148226

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3e06253547af Enable custom tabs by default r=sebastian https://hg.mozilla.org/integration/autoland/rev/3c03b94342b9 turn on CustomTabs via SwitchBoard r=sebastian

https://hg.mozilla.org/mozilla-central/rev/3e06253547af https://hg.mozilla.org/mozilla-central/rev/3c03b94342b9

Since we're not going to ship the GeckoApp impl. to beta, let's back this out.

Bug 1371561 is for backing out this back. We'll reopen current one when that lands.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=27cad9749cddf68e11fdd4e5d73dad84a8f8cf23 is the backout push.

Backout by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/3c60b0f8edb0 Backed out changeset 3c03b94342b9

This is an assigned P1 bug without activity in two weeks. If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword. Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

I wonder why this was backed out? All we would need to do is to enable/disable the switchboard experiment. No need to remove all the code.

Wesly, Nevin, we need someone to do this, preferably before the merge tomorrow.

I guess we can just land the attached patches and control via switchboard?

Hi Julian. Please help with this. Thank you!

Comment on attachment 8861872 [details] Bug 1329152 - turn on CustomTabs via SwitchBoard https://reviewboard.mozilla.org/r/133892/#review187382

Pushed by walkingice0204@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e692d1d1be1e Enable custom tabs by default r=sebastian https://hg.mozilla.org/integration/autoland/rev/7033e71f7929 turn on CustomTabs via SwitchBoard r=nechen,sebastian

Got confirmation from :jcheng on slack, then I rebased the patches to land. After these patches, CustomTabs is enabled in nightly, and only in nightly so far.

https://hg.mozilla.org/mozilla-central/rev/e692d1d1be1e https://hg.mozilla.org/mozilla-central/rev/7033e71f7929

Hey Joe, Nevin and Wesly, Did we turn this on with switchboard by default?

Nicole: Curretnly we only have nightly with 100% Other channels are not set yet. Julian: I forgot about the logic. I remember it was "default off", we look into the switchboard and then update it accordingly, right? Joe: Maybe we need to turn it on for all channels now? schema 1480618438089 name "custom-tabs" match appId "^org.mozilla.fennec.*$" buckets min "0" max "100" id "5e23b482-8800-47be-b6dc-1a3bb6e455d4" description "Allows apps to open tabs in a customized UI." last_modified 1493375228887

It is default off. CustomTabs won't be enabled until the user is in experiment via SwitchBoard. As your comment, now we only enable it in nightly.

let's turn this on 100% for beta. Thanks