Closed
Bug 1329186
Opened 8 years ago
Closed 8 years ago
(1) Use asyncOpen2() and (2) change nsILoadInfo.SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL when using a SystemPrincipal
Categories
(SeaMonkey :: General, defect)
Tracking
(seamonkey2.50+ fixed)
RESOLVED
FIXED
seamonkey2.50
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
iannbugzilla
:
review+
frg
:
feedback+
|
Details | Diff | Splinter Review |
See Bug 1328847 For more details (Port |Bug 1182569 - Use asyncOpen2() for docshell loads (nsJSProtocolHandler and nsURILoader)| to TB)
|
Assignee | |
Updated•8 years ago
|
Summary: Use asyncOpen2() and change nsILoadInfo.SEC_NORMAL to SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL → (1) Use asyncOpen2() and (2) change nsILoadInfo.SEC_NORMAL to SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL when using a SystemPrincipal
|
|
Assignee | |
Updated•8 years ago
|
Summary: (1) Use asyncOpen2() and (2) change nsILoadInfo.SEC_NORMAL to SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL when using a SystemPrincipal → (1) Use asyncOpen2() and (2) change nsILoadInfo.SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL when using a SystemPrincipal
|
|
Assignee | |
Comment 1•8 years ago
|
||
My build environment is broken so I can't test.
FRG: could you take this patch for a spin round the block? Thanks.
Attachment #8825355 -
Flags: review?(iann_bugzilla)
Attachment #8825355 -
Flags: feedback?(frgrahl)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Ooops wrong patch:
> My build environment is broken so I can't test.
> FRG: could you take this patch for a spin round the block? Thanks.
Attachment #8825355 -
Attachment is obsolete: true
Attachment #8825355 -
Flags: review?(iann_bugzilla)
Attachment #8825355 -
Flags: feedback?(frgrahl)
Attachment #8825356 -
Flags: review?(iann_bugzilla)
Attachment #8825356 -
Flags: feedback?(frgrahl)
|
|
||
Comment 3•8 years ago
|
||
Ptahc is a little bit bitrotted already:
$ hg import -f ../Bug1329186asyncOpen2.patch
applying ../Bug1329186asyncOpen2.patch
patching file suite/common/src/nsAbout.js
Hunk #1 FAILED at 46
1 out of 1 hunks FAILED -- saving rejects to file suite/common/src/nsAbout.js.rej
patching file suite/common/src/nsGopherProtocolStubHandler.js
Hunk #1 FAILED at 48
1 out of 1 hunks FAILED -- saving rejects to file suite/common/src/nsGopherProtocolStubHandler.js.rej
patching file suite/feeds/src/FeedConverter.js
Hunk #1 succeeded at 259 with fuzz 2 (offset -2 lines).
patching file suite/mailnews/addrbook/abCommon.js
Hunk #1 FAILED at 703
1 out of 1 hunks FAILED -- saving rejects to file suite/mailnews/addrbook/abCommon.js.rej
abort: patch failed to apply
|
|
||
Comment 4•8 years ago
|
||
unbitrotted patch
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8826843 [details] [diff] [review]
Bug1329186asyncOpen2-V2.patch
Unbitrotted patch gets and f+.
If this makes the web and SeaMonkey a better place should it be carried to 2.49 after review?
Attachment #8826843 -
Flags: feedback+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8825356 [details] [diff] [review]
Patch v1 proposed fix.
f+ for updated patch
Attachment #8825356 -
Flags: feedback?(frgrahl)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8826843 [details] [diff] [review]
Bug1329186asyncOpen2-V2.patch
(In reply to Frank-Rainer Grahl from comment #5)
> Comment on attachment 8826843 [details] [diff] [review]
> Bug1329186asyncOpen2-V2.patch
>
> Unbitrotted patch gets and f+.
>
> If this makes the web and SeaMonkey a better place should it be carried to
> 2.49 after review?
mozilla-central Bug 1182569 landed on Gecko 53 and didn't get backported. We may not be able to backport to ESR because the dependencies are not on Gecko ESR52.
Attachment #8826843 -
Flags: review?(iann_bugzilla)
Comment on attachment 8826843 [details] [diff] [review]
Bug1329186asyncOpen2-V2.patch
>+++ b/suite/browser/test/browser/browser_pluginplaypreview.js
>- channel.asyncOpen(this.listener, aContext);
>+ channel.asyncOpen2(this.listener, aContext);
Only takes one argument so just:
+ channel.asyncOpen2(this.listener);
>+++ b/suite/common/nsContextMenu.js
>+ channel.asyncOpen2(new SaveAsListener(), null);
Only takes one argument so just:
+ channel.asyncOpen2(new SaveAsListener());
>+++ b/suite/feeds/src/FeedConverter.js
>+ chromeChannel.asyncOpen2(this._listener, null);
Only takes one argument so just:
+ chromeChannel.asyncOpen2(this._listener);
r/a=me with those issues addressed.
Attachment #8826843 -
Flags: review?(iann_bugzilla) → review+
Attachment #8825356 -
Attachment is obsolete: true
Attachment #8825356 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 9•8 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/c0d44cd135763ae69491ccb887051e347050e15c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-seamonkey2.50:
--- → fixed
tracking-seamonkey2.50:
--- → +
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
You need to log in
before you can comment on or make changes to this bug.
Description
•