Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) Reporter
	Description • 8 years ago

The attachment reminder notification bar's text has low contrast.

First bad Daily: 20150824 (43.0a1)
This got mitigated for Thunderbird 45 in bug 1245926 (switch back to gtk2).

comm-central contains only a blocklist update: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=7965091ed556&tochange=01a3c10a11d3

Regression range for mozilla-central: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=22c34579ae0720e7d3dc39a22b9d33f13bc0198b&tochange=8a6045d14d6bd348a3b5bfeb55a9321e680cc93e

So this is a regression from bug 1187203.

There might be similar issues in the codebase.

The general GTK2 to GTK3 bug is bug 627699.

	Richard Marti (:Paenglab)
	Comment 1 • 8 years ago

We use the plain rule from https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/notification.css#7

I could override it with color: inherit; but I think this is a issue of the GTK integration which chooses the wrong color for -moz-gtk-info-bar-text.

Should this bug not move to toolkit?

	Karl Tomlinson (:karlt)
	Comment 2 • 8 years ago

Ambiance chooses low contrast colors for info bars, and Gecko is succeeding in using the same colors as the theme.

Fortunately this means that a different GTK theme can be selected and Gecko will use that.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) Reporter
	Comment 3 • 7 years ago

(In reply to Richard Marti (:Paenglab) from comment #1)
> Should this bug not move to toolkit?
Your decision, you have more expertise with this.

(In reply to Karl Tomlinson (:karlt) from comment #2)
> Ambiance chooses low contrast colors for info bars, and Gecko is succeeding
> in using the same colors as the theme.
This applies to notification bars with type="warning", but not with type="info" (like the datareporting notification in the second session after profile creation uses - it's high contrast).

To see such a notification bar in Firefox Nightly, go to http://www.popuptest.com/popuptest4.html and move the mouse over the link.

	Richard Marti (:Paenglab)
	Comment 4 • 7 years ago

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #3)
> 
> To see such a notification bar in Firefox Nightly, go to
> http://www.popuptest.com/popuptest4.html and move the mouse over the link.

This is a good example for Firefox. Moving to toolkit.

	Adolfo Jayme
	Comment 5 • 7 years ago

(In reply to Karl Tomlinson (:karlt) from comment #2)
> Ambiance chooses low contrast colors for info bars, and Gecko is succeeding
> in using the same colors as the theme.

Please file these kind of issues at https://launchpad.net/ubuntu-themes. I know the theme is almost orphaned by Canonical, but hopefully the external pressure will make them wake up.