J.C. Jones [:jcj] (he/him) Assignee
	Description • 8 years ago

Unit Tests for WebAuthn require Bug 1286312 to land, so moving them from Bug 1309284 into here to track.

	J.C. Jones [:jcj] (he/him) Assignee
	Comment 2 • 8 years ago

keeler - this code is identical to that which was pulled out of Bug 1309284, where this was marked as Part 4. I just changed the commit message.

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews)
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8825443 [details]
Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

https://reviewboard.mozilla.org/r/103600/#review104310

Ok - looks good to me.

::: dom/u2f/tests/test_webauthn_sameorigin.html:84
(Diff revision 1)
> +    .then(arrivingHereIsGood)
> +    .catch(arrivingHereIsBad),
> +
> +    // Test this origin with optional fields
> +    authn.makeCredential(acct, [param], chall,
> +                         {rpId: "user:pass@"+document.origin+":8888"})

nit: for these, I would either put spaces between the '+' operators or use template literals

::: dom/u2f/tests/u2futil.js:145
(Diff revision 1)
> +  }
> +
> +  u2fRegObj.keyHandle = bytesToBase64UrlSafe(u2fRegObj.keyHandleBytes);
> +
> +  return importPublicKey(u2fRegObj.publicKeyBytes)
> +  .then(function(keyObj){

nit: space before '{'

	J.C. Jones [:jcj] (he/him) Assignee
	Comment 7 • 8 years ago

Try run looks good, after consulting in #releng. Note that the mochitest-valgrind oranges are all tryserver bugs, they are not intended to be shown.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f0747d4d61af2f1ac6dc18408ff103b0e193a3a

Marking checkin-needed.

	Pulsebot
	Comment 8 • 8 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ea3744df8af6
WebAuthn Unit Tests: Add Unit Tests r=keeler

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ea3744df8af6