Closed Bug 1329898 Opened 8 years ago Closed 8 years ago

nsPasteNoFormattingCommand::IsCommandEnabled sends sync IPC messages unconditionally after set .innerHTML

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1317322

People

(Reporter: kanru, Unassigned)

References

Details

While profiling a big gslides performing pagedown from first page to last page I found we spent some time in IPC call after setInnerHTML. Given that reflow after a setInnerHTML is already slow, calling sync IPC after that only makes it worse. Ehsan suggests that maybe we can cache the Clipboard flavor in the content process instead of request it from parent when needed. https://clptr.io/2iyOaet
Flags: needinfo?(ehsan)
OSX doesn't have monitor listener of pasteboard. Windows, GTK and Android can create a listener for clipboard.
The patch in bug 1317322 will completely fix this bug by making HTMLEditor::CanPaste() not talk to the parent process in HTML documents. Duping.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ehsan)
Resolution: --- → DUPLICATE
(In reply to Makoto Kato [:m_kato] from comment #1) > OSX doesn't have monitor listener of pasteboard. Windows, GTK and Android > can create a listener for clipboard. I believe that with bug 1317322 fixed, there shouldn't be any other interesting consumers of HTMLEditor::CanPaste() for web content. If this performance issue comes up with other nsIClipboard consumers, we should consider what I suggested earlier... Not sure how we'd handle OSX though.
You need to log in before you can comment on or make changes to this bug.