Closed
Bug 1330000
Opened 8 years ago
Closed 8 years ago
Rename 'OS X' to 'macOS' on download pages / buttons
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: agibson, Assigned: anejaalisha)
Details
I believe all our download button code still refers to the Mac platform as `OS X`. Since Sierra [1] was released I believe the correct platform name should now be `macOS`. We should probably update this where appropriate on user facing components & pages.
[1] http://www.apple.com/macos/sierra/
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → anejaalisha
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Link to github pull request: https://github.com/mozilla/bedrock/pull/4603
Reporter | ||
Comment 2•8 years ago
|
||
Peter, before we make this change I'd like to run this by you in terms of any potential SEO impact. The change is renaming OSX to macOS in both our download buttons and on the main /download page.
For example: https://github.com/mozilla/bedrock/pull/4603/files#r98184514
I appreciate this isn't part of our sprint, but this bug is being worked on by a contributor.
Happy to chat about this change if you would like to discuss further before making a recommendation.
Flags: needinfo?(peter.german.bugs)
Are you referring to the data attributes on our download buttons?
If so, then my preference is to leave them as is so that our trend in downloads for firefox for macs remains within the same nomenclature. If we were to change it and wanted to see the trend in downloads of firefox for macs then we would have to pull the data across two different different values.
This won't have any SEO impact but would definitively impact the simplicity of pulling this data.
While I appreciate that this is no longer technically a 'correct' label, for our purposes it is better to have continuity than to have the perfect label.
Thanks for checking!
Flags: needinfo?(peter.german.bugs)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to pgerman from comment #3)
> Are you referring to the data attributes on our download buttons?
>
> If so, then my preference is to leave them as is so that our trend in
> downloads for firefox for macs remains within the same nomenclature. If we
> were to change it and wanted to see the trend in downloads of firefox for
> macs then we would have to pull the data across two different different
> values.
>
> This won't have any SEO impact but would definitively impact the simplicity
> of pulling this data.
>
> While I appreciate that this is no longer technically a 'correct' label, for
> our purposes it is better to have continuity than to have the perfect label.
>
> Thanks for checking!
No this doesn't have anything to do with data attributes - this is the human readable text that people see on our pages.
After discussing with Alex, I think that it makes the most sense to be accurate. It is a low SEO risk.
Thanks for clarifying!
Comment 6•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/751f0cb660db170cf448f223f1604892a3d244d3
Merge pull request #4603 from alisha17/bug-1330000-Rename-OSX-to-macOS-on-download-pages/buttons
Bug 1330000 - Rename 'OS X' to 'macOS' on download pages / buttons
Comment 7•8 years ago
|
||
This update has been pushed to production.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•