Closed
Bug 1330314
Opened 8 years ago
Closed 8 years ago
Learn More links should only be 10px after the text
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | verified |
People
(Reporter: jaws, Assigned: xfergusi, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
From page 7 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509 (and specified more explicitly on slide 5 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509
This was missed in bug 1324170.
Updated•8 years ago
|
Assignee: nobody → xfergusi
Mentor: mconley, jaws
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8829678 [details]
Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer.
https://reviewboard.mozilla.org/r/106678/#review107990
Please run 'hg histedit' and choose the 'mess' option to edit the commit message for your patch, then re-push it for review. Your commit message should describe what and why your patch is changing. It should also include the bug number at the beginning and the reviewer at the end. Once you do this we can get your patch landed in mozilla-central.
Your commit message is currently: "Bug 1330314 Adding adding 10px after the text for Learn More links. r?jaws"
Your commit message should be: "Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer. r?jaws"
Attachment #8829678 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f43d635de8d
Reduce the inline-start margin for Learn More links to keep the link contextually closer. r=jaws
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 6•8 years ago
|
||
I've tested on Windows 7 x64, Ubuntu 14.04 x64 and Mac OS X 10.11 using latest Aurora 54.0a2 (2017-03-29) and I have one mention here: there is more than 10px between the text and the "Learn More" links:
- under DRM Content (Content tab) - 18px
- under Notifications (Content tab) - 11px
- under Tracking (Privacy tab) - 18px
- under Data Choices (Advanced tab) - 38px/12px/61px
This is expected?
Shouldn't we keep the same distance between the text and the "Learn More" links?
Please see the attachments "issue1.png" and "issue2.png".
Comment 7•8 years ago
|
||
Updated•8 years ago
|
Flags: needinfo?(jaws)
Reporter | ||
Comment 8•8 years ago
|
||
Hi Camelia, can you please file a bug for the DRM Content, Tracking Protection, and Data Choices ones? Let's skip the 11px one since it's close enough.
Flags: needinfo?(jaws)
Comment 9•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> Hi Camelia, can you please file a bug for the DRM Content, Tracking
> Protection, and Data Choices ones? Let's skip the 11px one since it's close
> enough.
I filled bug 1352420.
Marking this bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•