Closed
Bug 1330318
Opened 8 years ago
Closed 8 years ago
Setting b=TIAS caps us at 2kbps
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
(deleted),
patch
|
pehrsons
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1320101 +++
In bug 1320101 it was noted that mDroppedFrames is increasing at a crazy rate.
It appears a set of parens were lost in the conversion from CodecStatistics.cpp to the Call interface in the 49 update
Assignee | ||
Updated•8 years ago
|
Rank: 17
Assignee | ||
Comment 1•8 years ago
|
||
haven't tried it yet... compare to CodecStatistics.cpp's (old) impl, still in the tree though not used now
Attachment #8825821 -
Flags: review?(pehrson)
Comment 2•8 years ago
|
||
Comment on attachment 8825821 [details] [diff] [review]
Fix droppedFrames statistic in webrtc, and improve debugs
Review of attachment 8825821 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
@@ +123,5 @@
> StreamStatistics::Update(aStats.encode_frame_rate, aStats.media_bitrate_bps);
> if (!aStats.substreams.empty()) {
> const webrtc::FrameCounts& fc =
> aStats.substreams.begin()->second.frame_counts;
> + CSFLogVerbose(logTag, "%s: framerate: %u, bitrate: %u, dropped frames delta: %u", __FUNCTION__,
Line looks a bit long.
Attachment #8825821 -
Flags: review?(pehrson) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac80b556e979
Fix droppedFrames statistic in webrtc, and improve debugs r=pehrsons
Comment 4•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•