Steve Fink [:sfink] [:s:] Reporter
	Description • 8 years ago

Right now, enabling profiling also enables JIT optimization tracking. At least in one profile, we had 500ms in findAllocationSite out of a <10s run (I don't remember which one this was, sorry.) So when not using the opt tracking info, I would like to turn it off while profiling.

	Hannes Verschore [:h4writer] Assignee
	Comment 2 • 8 years ago

This disable tracking optimization by default. It is currently not used and it is bad that it is skewing the results of the SPS profiler. When using IONFLAGS=trackopts it is enabled by default again.

Just setting JitOptions.disableOptimizationTracking to false (in c++) should enable it. I.e. that is our place to flip things. It can be easily patched to have an about:config entry.

Also setting the environment variable JIT_OPTION_disableOptimizationTracking=false will enable the optimization tracking again. (in all sort of builds).

	Shu-yu Guo [:shu]
	Comment 3 • 8 years ago

Comment on attachment 8834500 [details] [diff] [review]
Disable tracking optimizations by default

Review of attachment 8834500 [details] [diff] [review]:
-----------------------------------------------------------------

Let me pour one out.

	Pulsebot
	Comment 4 • 8 years ago

Pushed by hv1989@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d1d2440c9a
Don't enable optimization tracking by default, r=shu

	Carsten Book [:Tomcat]
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/40d1d2440c9a