Closed
Bug 1330574
Opened 8 years ago
Closed 8 years ago
Correct WebRenderContainerLayer overflow rect
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: ethlin, Assigned: ethlin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
The overflow rect in WRContainerLayer is wrong. It should be same as other WRXXXLayer. I'll fix it.
|
Assignee | |
Updated•8 years ago
|
Summary: Fix WebRenderContainerLayer overflow rect → Correct WebRenderContainerLayer overflow rect
|
|
Assignee | |
Comment 1•8 years ago
|
||
The overflow rect's top left point should be zero. It's different from 'relBounds'.
Attachment #8826117 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Based on the try server result[1] with Part1 patch, I mark some reftests as passing.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d86e73a3a9fe7b1ca1025817f180275452d9c4c5
Attachment #8826118 -
Flags: review?(bugmail)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8826117 [details] [diff] [review]
Part1. Correct overflow rect
Review of attachment 8826117 [details] [diff] [review]:
-----------------------------------------------------------------
Update the printf as well. I don't know if anybody is still using that but might as well keep it up to date.
Attachment #8826117 -
Flags: review?(bugmail) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8826118 [details] [diff] [review]
Part2. mark some reftests as passing
Review of attachment 8826118 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, this fixes a lot!
Attachment #8826118 -
Flags: review?(bugmail) → review+
|
|
||
Updated•8 years ago
|
Blocks: webrender-reftests
|
|
Assignee | |
Comment 5•8 years ago
|
||
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/873c64225267
Part1. Correct WebRenderContainerLayer overflow rect. r=kats
https://hg.mozilla.org/projects/graphics/rev/248399829d40
Part2. Mask some reftests as passing after fix WebRenderContainerLayer overflow rect. r=kats
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/90ff62d4c2b9
Remove unnecessary change of testcase. r=gfx?
|
|
||
Updated•8 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•