Closed Bug 1330652 Opened 8 years ago Closed 8 years ago

SETA - job priorities endpoint always returns data for mozilla-inbound

Categories

(Tree Management Graveyard :: Treeherder: SETA, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: rwood)

References

Details

Attachments

(1 file, 1 obsolete file)

It seems that we always return data from mozilla-inbound even if we choose another project name in the url: https://treeherder.mozilla.org/api/project/autoland/seta/job-priorities/?build_system_type=buildbot&priority=5&format=json This is an easy fix.
Assignee: nobody → armenzg
Attachment #8826244 - Flags: review?(emorley)
Blocks: 1286358
rwood, would you mind addressing any review comments from emorley? When the code lands we also need to close bug 1330677. Thank you so much!
Comment on attachment 8826244 [details] [treeherder] armenzg:seta_job_priorities > mozilla:master I've left some comments on the PR :-) (I didn't review straight away since I know Armen is away; though thinking about it not sure if rwood was going to take over, if so sorry for the delay)
Attachment #8826244 - Flags: review?(emorley)
Np at all, thanks Ed!
Assignee: armenzg → rwood
Status: NEW → ASSIGNED
Comment on attachment 8826244 [details] [treeherder] armenzg:seta_job_priorities > mozilla:master Closing :armenzg's original PR (took over this patch while it was under review, so creating a new PR with :armenzg's orignal patch + my updates).
Attachment #8826244 - Attachment is obsolete: true
Attachment #8833132 - Flags: review?(emorley)
Comment on attachment 8833132 [details] [treeherder] rwood-moz:bug1330652 > mozilla:master Travis is failing. Could you also reorganise the commits such that the latest updates are squashed in with their parents and the merge commit is gone? Aside from that, think this is good to land shortly :-)
Attachment #8833132 - Flags: review?(emorley)
Comment on attachment 8833132 [details] [treeherder] rwood-moz:bug1330652 > mozilla:master Thanks Ed, PR updated
Attachment #8833132 - Flags: review?(emorley)
Attachment #8833132 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f6ac262dd07b8cac14c5fe38c1f3bd6c642e5af7 Bug 1330652 - fix job priorities endpoint so it returns data from correct repo (#2128) * Bug 1330677 - Allow calling runnable jobs API without having to pass the Gecko decision task id. This is useful if all you care about is to determine what is most up-to-date list of tasks that can be scheduled. In the future, this will allow for determining the "current set of runnable jobs" on a schedule (caching the latest values) rather on per API call. * Bug 1330652 - SETA - Fix job priorities endpoint We were not passing the project name down to the functionality that retrieves runnable jobs, thus, using 'mozilla-inbound' by default. This change starts using the simplified ref_data_names() method which also takes the project name. This also paves the way to drop Treecodes from the code.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Treeherder → Treeherder: SETA
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: