Closed Bug 1330873 Opened 8 years ago Closed 8 years ago

media/libvpx/libvpx/vp8/common/alloccommon.c:12:24: fatal error: vpx_config.h: No such file or directory

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1330873 - Fallback to vpx_config.* from Linux on Tier3 platforms.
(deleted), text/x-review-board-request
jesup
: review+
Details
Bug 1328744 imposed platform whitelist for x86 and x86_64 which stems from upstream confusing POSIX-like systems with Linux. Let's ignore "mac" and "linux" configs being the same for now. ;) media/libvpx/libvpx/vp8/common/alloccommon.c:12:10: fatal error: 'vpx_config.h' file not found #include "vpx_config.h" ^~~~~~~~~~~~~~ 1 error generated.
Apologies for the breakage. This patch looks ideal. I should have realized all the *nix configs would fall in the same bucket. Historically we've broken Mac/Darwin out separately because of compiler/Xcode issues. As you noticed this could be consolidated now.
Comment on attachment 8826476 [details] Bug 1330873 - Fallback to vpx_config.* from Linux on Tier3 platforms. https://reviewboard.mozilla.org/r/104440/#review105328 ::: media/libvpx/moz.build:25 (Diff revision 1) > + else: > + ASFLAGS += [ '-I%s/media/libvpx/config/linux/x64/' % TOPSRCDIR ] Add a comment along the lines of # Linux, Android, BSD, etc ::: media/libvpx/moz.build:37 (Diff revision 1) > + else: > + ASFLAGS += [ '-I%s/media/libvpx/config/linux/ia32/' % TOPSRCDIR ] > + CFLAGS += [ '-I%s/media/libvpx/config/linux/ia32/' % TOPSRCDIR ] Ditto
Attachment #8826476 - Flags: review+
Attachment #8826476 - Flags: review?(giles)
Stole the review
Comment on attachment 8826476 [details] Bug 1330873 - Fallback to vpx_config.* from Linux on Tier3 platforms. https://reviewboard.mozilla.org/r/104440/#review105334 ::: media/libvpx/moz.build:25 (Diff revision 2) > ASFLAGS += [ '-I%s/media/libvpx/config/win/x64/' % TOPSRCDIR ] > CFLAGS += [ '-I%s/media/libvpx/config/win/x64/' % TOPSRCDIR ] > elif CONFIG['OS_TARGET'] == 'Darwin': > ASFLAGS += [ '-I%s/media/libvpx/config/mac/x64/' % TOPSRCDIR ] > CFLAGS += [ '-I%s/media/libvpx/config/mac/x64/' % TOPSRCDIR ] > + else: # Android, Linux, BSDs, etc. This is similar to `#else // Linux` style in C preprocessor. Or did you want the comments on separate lines? If **not** can you mark `checkin-needed` or click on `Automation -> Land Commits` ?
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d5214fa2276 Fallback to vpx_config.* from Linux on Tier3 platforms. r=jesup
Comment on attachment 8826476 [details] Bug 1330873 - Fallback to vpx_config.* from Linux on Tier3 platforms. https://reviewboard.mozilla.org/r/104440/#review105370 ::: media/libvpx/moz.build:25 (Diff revision 2) > ASFLAGS += [ '-I%s/media/libvpx/config/win/x64/' % TOPSRCDIR ] > CFLAGS += [ '-I%s/media/libvpx/config/win/x64/' % TOPSRCDIR ] > elif CONFIG['OS_TARGET'] == 'Darwin': > ASFLAGS += [ '-I%s/media/libvpx/config/mac/x64/' % TOPSRCDIR ] > CFLAGS += [ '-I%s/media/libvpx/config/mac/x64/' % TOPSRCDIR ] > + else: # Android, Linux, BSDs, etc. On the same line is fine I think. Thanks!
https://hg.mozilla.org/mozilla-central/rev/6d5214fa2276
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: