We need this for stylo bindgen, so we might as well submit the patches here to have some record of where the stylo bindgen clang came from.

We're going to need a separate version of cmake, and it seems better to limit the downloading of that separate version to the builds that need it, rather than downloading it for every single one of our automation builds.

Clang 3.9+ requires a newer version of cmake than is installed on our Linux images.

The return-empty-string-non-mangled.patch apparently landed in r249437 upstream, so we don't need to carry around our own version. The patch is still nominally used for building clang on Mac, so I have not removed it from version control.

Comment on attachment 8826646 [details] [diff] [review] part 1 - add a separate tooltool manifest for building clang Review of attachment 8826646 [details] [diff] [review]: ----------------------------------------------------------------- See the following r- for the reason why. :-)

Comment on attachment 8826647 [details] [diff] [review] part 2 - use a newer version of cmake for building clang on linux Review of attachment 8826647 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/config/tooltool-manifests/linux64/build-clang.manifest @@ +32,5 @@ > "digest": "b89c40dbf28c2bd54fadf017c15a8789f6e7611252a623cc3a1507e3dd6fc9e5a50d746e81776ba856e33fdc99b4a6413ba7c3ac0aed5f4835705da2b758ef22", > "size": 1020700 > +}, > +{ > +"version": "cmake 3.4.3, repacked from cmake.org", This should not be needed. I upgraded cmake to 3.7 in bug 1324492 which should be sufficient for you.

Comment on attachment 8826649 [details] [diff] [review] part 3 - update building clang for linux to version 3.9 Review of attachment 8826649 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/build-clang/clang-static-analysis-linux64.json @@ -1,2 @@ > { > - "llvm_revision": "262557", We try to not end up with a ton of different clang versions we use. Can you please update clang-static-analysis-macosx64.json in a follow-up as well?

I'm going to land just part 3, then, since it doesn't really depend on parts 1 and 2. (In reply to :Ehsan Akhgari from comment #6) > We try to not end up with a ton of different clang versions we use. Can you > please update clang-static-analysis-macosx64.json in a follow-up as well? I can do that; the macosx64.json one is a little wonky because we can't actually build that on infrastructure AFAIK. :(

(In reply to Nathan Froyd [:froydnj] from comment #7) > (In reply to :Ehsan Akhgari from comment #6) > > We try to not end up with a ton of different clang versions we use. Can you > > please update clang-static-analysis-macosx64.json in a follow-up as well? > > I can do that; the macosx64.json one is a little wonky because we can't > actually build that on infrastructure AFAIK. :( Oh I forgot about that, yes. But the good news is that in bug 1328199, I added support for cross-compiling clang for OSX on Linux, and I bet with a bit of work we can enable those builds on the infra similarly. But since that may be a bit more than what you signed up for, I'll work on that myself.

Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eee4bec1fa0b update building clang for linux to version 3.9; r=ehsan

Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5392e837645f follow-up - delete trailng comma in JSON file; r=me

https://hg.mozilla.org/mozilla-central/rev/eee4bec1fa0b https://hg.mozilla.org/mozilla-central/rev/5392e837645f