kernp25 Reporter
	Description • 8 years ago

When blocking images with webRequest.onBeforeRequest, the user should be able to load the blocked image by using the "Reload Image" item in the context menu.

Maybe webRequest.onBeforeRequest should not fire for this case?
Or, how we can detect, if the user loaded the image by using right-click -> Reload Image?

	Caitlin Neiman [:caitmuenster]
	Comment 1 • 8 years ago

To be discussed at 2/21 WebExtensions triage meeting. 

Agenda: https://docs.google.com/document/d/1H4sjnRFc87NZXZsM6XIgwWaoV2bdRFepiG28G7WzgPs/edit

	Giorgio Maone [:ma1]
	Comment 2 • 8 years ago

I believe "Reload Image" should not override a policy decision made by a (security/privacy) extension, because the user issuing this command is unlikely to have all the context which the extension had to make that decision.
However the extension, of course, should provide some (Click to Play?) UI to revert the block, giving user  enough information to make an educated choice. That's what usually happens with adblockers and NoScript, but this needs something like Bug 1210990 to be effectively implemented.

	kernp25 Reporter
	Comment 3 • 8 years ago

The idea is a image block add-on like this: https://addons.mozilla.org/en-US/firefox/addon/imglikeopera/
If the user wants to load the blocked image he can right-click on the image and choose "Reload Image" to load the blocked (blocked mostly for performance reason (e.g to load the webpage faster) image.

(In reply to Giorgio Maone [:mao] from comment #2)
> I believe "Reload Image" should not override a policy decision made by a
> (security/privacy) extension, because the user issuing this command is
> unlikely to have all the context which the extension had to make that
> decision.

This add-on (webextension): https://addons.mozilla.org/en-US/firefox/addon/html-content-blocker/
also blocks images but the blocked images will not appear on the webpage because there hidden. So the user cannot right-click and choose "Reload Image".

Maybe the (security/privacy) extension can hide the image so the user cannot right-click and choose "Reload Image"?

It doesn't make sense if there is a "Reload Image" context menu item but the item does nothing. If the extension developer doesn't want the image to be loaded he can hide the image and adds his own (Click to Play?) UI to allow the image to be loaded.

Reload Image should not be blocked by webRequest because the user wants to load the image.

	Andy McKay
	Comment 4 • 8 years ago

Agree with Giorgio that we should always send the webRequest event to webextensions and not override the policy of the extension. It can then be put in the extension author the ability to choose to block the webrequest or not. 

The context menu "Reload Image" shows up when an image fails to load. The extension can track errors and see if it should let repeated requests through. At this point I'd that bug 1210990 might happen and that would give the extension more ability to control this sort of thing.