Closed
Bug 1331571
Opened 8 years ago
Closed 8 years ago
Remove Intel Power Gadget integration from the profiler
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
I'm pretty sure nobody has ever used this. I didn't even when I was working on Project Candle and actively investigating power consumption in Firefox. As https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Power_profiling_overview says:
> observations made during power profiling — even more than with other kinds of
> profiling — can disturb what is being observed. For example, the Gecko
> Profiler takes samples at 1000Hz using a timer. Each of these samples can
> trigger a wakeup, which consumes power and obscures Firefox's natural wakeup
> patterns. For this reason, integrating power measurements into the Gecko
> Profiler is unlikely to be useful, and other power profiling tools typically
> use much lower sampling rates (e.g. 1Hz.)
Let's just remove the code.
Assignee | ||
Comment 1•8 years ago
|
||
Nobody has ever used this, and measuring power consumption while running a
sampling profiler at 1000 Hz isn't a good idea.
Attachment #8827364 -
Flags: review?(mstange)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Bug 769431 added this code, FWIW.
Assignee | ||
Comment 3•8 years ago
|
||
It's possible that Cleopatra should be updated as well.
Assignee | ||
Updated•8 years ago
|
Blocks: profiler-cleanup
Comment 4•8 years ago
|
||
Comment on attachment 8827364 [details] [diff] [review]
Remove Intel Power Gadget integration from the compiler
Review of attachment 8827364 [details] [diff] [review]:
-----------------------------------------------------------------
You missed some stuff in ProfileEntry.cpp: mPower, POWER, and the 'p' profile buffer entries.
Attachment #8827364 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0ca4bad5c3449b4f0ee22d66bc051f40f044fb
Bug 1331571 - Remove Intel Power Gadget integration from the compiler. r=mstange.
Assignee | ||
Comment 6•8 years ago
|
||
Whoops, this bug and commit should have said "profiler" instead of "compiler". Oh well.
Summary: Remove Intel Power Gadget integration from the compiler → Remove Intel Power Gadget integration from the profiler
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•