Closed
Bug 1331766
Opened 8 years ago
Closed 8 years ago
childCrashNotifyPipe not freed in XP_MACOSX case
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
From https://bugzilla.mozilla.org/show_bug.cgi?id=1060419#c139.
nsExceptionHandler sets childCrashNotifyPipe in the XP_MACOSX case here:
https://dxr.mozilla.org/mozilla-central/rev/3e275d37a06236981bff399b7d7aa0646be3fee7/toolkit/crashreporter/nsExceptionHandler.cpp#3531
This is also done for XP_WIN as well. For this case it is freed:
https://dxr.mozilla.org/mozilla-central/rev/3e275d37a06236981bff399b7d7aa0646be3fee7/toolkit/crashreporter/nsExceptionHandler.cpp#3582
.. this freeing is not done for XP_MACOSX, but should be.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ttromey
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8864292 [details]
Bug 1331766 - free childCrashNotifyPipe on XP_MACOSX;
https://reviewboard.mozilla.org/r/135916/#review138974
Attachment #8864292 -
Flags: review?(nfroyd) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e62fbf8f6ef
free childCrashNotifyPipe on XP_MACOSX; r=froydnj
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•