Closed
Bug 1332258
Opened 8 years ago
Closed 8 years ago
[RTL] Faded text sometimes becomes blank after scrolling
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: maliu, Assigned: maliu)
References
Details
(Keywords: rtl)
Attachments
(1 file)
STR:
1. Open many tabs mixed with LTR and RTL titled web page.
2. Open History tab in Home page.
3. Scroll up/down.
AR:
Some rows are blank when sometimes title appear back on.
attachment 8827524 [details] - Before scrolling
attachment 8827525 [details] - After scrolling
Thanks for opening this bug for me, Max :)
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828390 [details]
Bug 1332258 - Reset text fading gradient to null when text direction changed,
https://reviewboard.mozilla.org/r/105818/#review106742
::: mobile/android/base/java/org/mozilla/gecko/widget/FadedSingleColorTextView.java:55
(Diff revision 1)
> + final boolean isTextDirectionRtl = mIsTextDirectionRtl;
> + if (!TextUtils.isEmpty(text)) {
> - mIsTextDirectionRtl = BidiFormatter.getInstance().isRtl((String) text);
> + mIsTextDirectionRtl = BidiFormatter.getInstance().isRtl((String) text);
> - if (mIsTextDirectionRtl) {
> - setTextDirection(TEXT_DIRECTION_RTL);
> }
> + if (mIsTextDirectionRtl != isTextDirectionRtl) {
> + mTextGradient = null;
It's a bit confusing that isTextDirectionRtl and mIsTextDirectionRtl is basically the same name. Maybe the code is easier to follow if it's named currentTextDirectionRtl or previousTextDirectionRtl?
Attachment #8828390 -
Flags: review?(s.kaspari) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e4d9a133fb58
Reset text fading gradient to null when text direction changed, r=sebastian
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•