Closed Bug 1332375 Opened 8 years ago Closed 8 years ago

Rename leftover devedition/urlbar-history-dropmarker.svg to compacttheme/urlbar-history-dropmarker.svg

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 + wontfix
firefox54 + fixed

People

(Reporter: Gijs, Assigned: gohikearock, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 1 obsolete file)

mypatch.diff
(deleted), patch
dao
: review+
Details | Diff | Splinter Review
[Tracking Requested - why for this release]: should not keep talking about devedition internally as it's confusing Looks like there's still a leftover devedition subdirectory in browser/themes/shared/, with 1 file in it. We should tidy up that loose end.
We should fix this, and as with many bugs it would be nice if we took care of this soon rather than sometime, but there's no urgent need to get it done in 53 as far as I can tell.
Priority: -- → P3
I think we should just make sure it ships with the rest of the s/devedition theme/compact theme/ changes.
It seems like a code hygiene issue to me, i.e. it's potentially confusing for us going forward but it doesn't matter whether we ship it. Or is there some impact for users that I'm missing?
If you end up fixing it for 54, please go ahead and request uplift.
status-firefox53: affected → fix-optional
status-firefox54: --- → affected
tracking-firefox53: ? → +
tracking-firefox54: --- → +
It seems that there's no impact for users, so no reason why we'd uplift this.
status-firefox53: fix-optional → wontfix
Mentor: dao+bmo
Keywords: good-first-bug
Whiteboard: [good first bug][lang=css]
Version: 53 Branch → Trunk
Can i take this as my first bug? And can i get a mentor to help me out? Thanks
(In reply to Chandler from comment #6) > Can i take this as my first bug? And can i get a mentor to help me out? > Thanks Sure. Here's what you need to do: rename the file from browser/themes/shared/devedition/urlbar-history-dropmarker.svg to browser/themes/shared/compacttheme/urlbar-history-dropmarker.svg and then update the references to it: https://dxr.mozilla.org/mozilla-central/search?q=urlbar-history-dropmarker.svg+-path%3Aobj&redirect=false
so really im just moving this file. deleting the folder "devedition" and then updating the references? How do I update the references? Thanks
Ohhhh never mind ignore the last comment. Although i still need to know how to update the reference? Thanks
(In reply to Chandler from comment #9) > Ohhhh never mind ignore the last comment. Although i still need to know how > to update the reference? Thanks Just replace devedition/ with compacttheme/ in those files.
(In reply to Dão Gottwald [:dao] from comment #10) > (In reply to Chandler from comment #9) > > Ohhhh never mind ignore the last comment. Although i still need to know how > > to update the reference? Thanks > > Just replace devedition/ with compacttheme/ in those files. How can I commit the changes in for review?
(In reply to Chandler from comment #11) > How can I commit the changes in for review? The easiest way to create a patch is hg diff > ~/mypatch.diff. You can then upload the patch as an attachment on this page.
Attached patch Possible Patch (obsolete) (deleted) — — Splinter Review
Attachment #8836971 - Flags: review?(dao+bmo)
Comment on attachment 8836971 [details] [diff] [review] Possible Patch This correctly renames the SVG file but doesn't update the other files referring to this image.
Attachment #8836971 - Flags: review?(dao+bmo) → review-
Attached patch mypatch.diff (deleted) — — Splinter Review
Attachment #8837121 - Flags: review?(dao+bmo)
Comment on attachment 8837121 [details] [diff] [review] mypatch.diff Looks good. Thanks!
Attachment #8837121 - Flags: review?(dao+bmo) → review+
Attachment #8836971 - Attachment is obsolete: true
Assignee: nobody → gohikearock
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2dd80907a0f Rename leftover devedition/urlbar-history-dropmarker.svg to compacttheme/urlbar-history-dropmarker.svg. r=dao
Thanks! Is there anything else here I need to do?
(In reply to Chandler from comment #18) > Thanks! Is there anything else here I need to do? Everything's taken care of. I pushed the patch to mozilla-inbound from where it will be merged to mozilla-central, unless the patch causes problems.
https://hg.mozilla.org/mozilla-central/rev/a2dd80907a0f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: