Carsten Book [:Tomcat] Reporter
	Description • 7 years ago

Found via uplift simulations 

TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_970511_undo_restore_default.js | Theme reset to default - Got [object Object], expected null 

https://treeherder.mozilla.org/logviewer.html#?job_id=70596451&repo=try&lineNumber=2788

Gijs could you take a look again ?

	:Gijs (he/him) Assignee
	Comment 2 • 7 years ago

browser_1007336_lwthemes_in_customize_mode.js is also failing, sigh.

	:Gijs (he/him) Assignee
	Comment 3 • 7 years ago

In fact, just fixing the tests here isn't going to work, because bug 1306561 made CUI use:

    if (Services.prefs.getDefaultBranch("").getCharPref(kPrefSelectedThemeID) !=
        Services.prefs.getCharPref(kPrefSelectedThemeID)) {


This doesn't work, because for tests the test config with prefs_general.js uses user_pref to change the pref value to "", which means that these values are different and the result is failing this check and therefore failing tests, like the oodles of failures in the windows bc3 runs on https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ae830802da242e39f31edb3926547b75b105a45&selectedJob=70610880 .

The simplest thing here is just going to be to back out and reopen 1306561. Merge day is on Monday and revamping how we set the default for tests, or removing that pref set without any ideas what else it'll affect/break is a bad idea.

	:Gijs (he/him) Assignee
	Comment 4 • 7 years ago

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/dc5a594e63f27286ea6a8485075fda431c936ddd

	:Gijs (he/him) Assignee
	Comment 5 • 7 years ago

Resolved via backout of bug 1306561.