Closed
Bug 1332625
Opened 8 years ago
Closed 8 years ago
about:support on Android should not link to about:profiles (broken link)
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: tomer, Assigned: tomer)
References
()
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
standard8
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
bug 1179129 introduced a link to about:profiles from about:support. Since about:profiles doesn't exists on the Android port, I see no point in having such link on about:support.
Steps to reproduce:
a. Open about:support on Android.
b. Scroll down to the about:profiles link in the last row of the Application Basics table.
c. Click (or tap).
Actual result:
The address isn't valid error message, since about:profiles isn't available (not listed on about:about as well)
Expected result:
Implement about:profiles or have the link disappear.
This problem affects all versions of Firefox for Android, from release to nightly.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8828814 -
Flags: review?(standard8)
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)
https://reviewboard.mozilla.org/r/106108/#review108856
Sorry for the delay in getting to this. Looks good. r=Standard8.
Attachment #8828814 -
Flags: review?(standard8) → review+
Assignee | ||
Updated•8 years ago
|
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8c317b40aa10
about:support on Android should not link to about:profiles (broken link) r=standard8
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 5•8 years ago
|
||
Should this be uplifted to aurora and/or beta?
Flags: needinfo?(tomer.moz.bugs)
Assignee | ||
Comment 6•8 years ago
|
||
[Tracking Requested - why for this release]: Low risk; Link has been removed using ifdef.
tracking-firefox52:
--- → ?
tracking-firefox53:
--- → ?
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)
Approval Request Comment
[Feature/Bug causing the regression]: There is no about:profiles on Android at the moment.
[User impact if declined]: Broken link.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]: Can be confirmed by myself.
[Needs manual test from QE? If yes, steps to reproduce]: Verification would be great, but not sure if necessary.
[List of other uplifts needed for the feature/fix]: I am planning to file similar bugs on this page, but there is no dependencies.
[Is the change risky?]: Probably not.
[Why is the change risky/not risky?]: Link removed using ifdef.
[String changes made/needed]:
Flags: needinfo?(tomer.moz.bugs)
Attachment #8828814 -
Flags: approval-mozilla-beta?
Attachment #8828814 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)
Thanks for catching this! Let's uplift to aurora and beta.
Attachment #8828814 -
Flags: approval-mozilla-beta?
Attachment #8828814 -
Flags: approval-mozilla-beta+
Attachment #8828814 -
Flags: approval-mozilla-aurora?
Attachment #8828814 -
Flags: approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
Comment 10•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•