Now that the XPCOM glue isn't a thing, it's confusing to have a bunch of files still in the xpcom/glue directory. This bug tracks moving these files to other locations. Most of this is really simple. nsStringAPI/nsStringGlue is hard. I'll probably split those out into a separate bug/patch because there are dependencies in webrtc.

Comment on attachment 8829420 [details] Bug 1332631 part A - remove two files which aren't referenced or used, https://reviewboard.mozilla.org/r/106526/#review107648

Comment on attachment 8829421 [details] Bug 1332631 part B - file moves from xpcom/glue to xpcom/base, https://reviewboard.mozilla.org/r/106528/#review107650 ::: xpcom/base/nsSystemInfo.cpp:80 (Diff revision 1) > // system call to discover the appropriate value is not thread-safe, > // so we must call it before going multithreaded, but nsSystemInfo::Init > // only happens well after that point. > uint32_t nsSystemInfo::gUserUmask = 0; > > +using namespace mozilla::dom; Why is this necessary?

Comment on attachment 8829422 [details] Bug 1332631 part C - file moves from xpcom/glue to xpcom/ds, https://reviewboard.mozilla.org/r/106530/#review107652

Comment on attachment 8829423 [details] Bug 1332631 part D - file moves from xpcom/glue to xpcom/threads, https://reviewboard.mozilla.org/r/106532/#review107654

Comment on attachment 8829424 [details] Bug 1332631 part E - file moves from xpcom/glue to xpcom/string, https://reviewboard.mozilla.org/r/106534/#review107656

Comment on attachment 8829425 [details] Bug 1332631 part F - move nsXPTCUtils.h to xpcom/reflect/xptcall, https://reviewboard.mozilla.org/r/106536/#review107662

Comment on attachment 8829426 [details] Bug 1332631 part G - file moves from xpcom/glue to xpcom/components, and remove GenericModule which is no longer useful, https://reviewboard.mozilla.org/r/106538/#review107664

Comment on attachment 8829427 [details] Bug 1332631 part H - move gtests from xpcom/glue to xpcom/tests, and unify the two TestThreadUtils.cpp into one file, https://reviewboard.mozilla.org/r/106540/#review107666 I did not look closely at the new content; I am assuming that your cut-and-paste buttons work OK. ::: xpcom/tests/gtest/TestThreadUtils.cpp:386 (Diff revision 1) > +TEST(ThreadUtils, TypeTraits) > +{ I am unsure that a gtest with no actual `EXPECT_*` or `ASSERT_*` calls is going to work very well.

> > +using namespace mozilla::dom; > > Why is this necessary? It fixes a unified build bustage because of a type from PContent which is used in this file. > I am unsure that a gtest with no actual `EXPECT_*` or `ASSERT_*` calls is > going to work very well. Indeed I'm not sure this needs to be a TEST. It's basically just a bunch of static_asserts. But it does pass and was strictly copied, so I think I'll keep it for now.

Pushed by bsmedberg@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/affff812d187 part A - remove two files which aren't referenced or used, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/19391089d475 part B - file moves from xpcom/glue to xpcom/base, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/a3af628d69b3 part C - file moves from xpcom/glue to xpcom/ds, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/cade3cd4cc6f part D - file moves from xpcom/glue to xpcom/threads, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/6434aad0c30c part E - file moves from xpcom/glue to xpcom/string, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/c6dea69a5022 part F - move nsXPTCUtils.h to xpcom/reflect/xptcall, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/f30012f9ed37 part G - file moves from xpcom/glue to xpcom/components, and remove GenericModule which is no longer useful, r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/43fabd330b94 part H - move gtests from xpcom/glue to xpcom/tests, and unify the two TestThreadUtils.cpp into one file, r=froydnj

https://hg.mozilla.org/mozilla-central/rev/affff812d187 https://hg.mozilla.org/mozilla-central/rev/19391089d475 https://hg.mozilla.org/mozilla-central/rev/a3af628d69b3 https://hg.mozilla.org/mozilla-central/rev/cade3cd4cc6f https://hg.mozilla.org/mozilla-central/rev/6434aad0c30c https://hg.mozilla.org/mozilla-central/rev/c6dea69a5022 https://hg.mozilla.org/mozilla-central/rev/f30012f9ed37 https://hg.mozilla.org/mozilla-central/rev/43fabd330b94