Closed
Bug 1332644
Opened 8 years ago
Closed 8 years ago
Remove 'retentionDays' from sendTelemetryPing call in CrashManager.jsm
Categories
(Toolkit :: Telemetry, defect, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: marco, Assigned: kevin.gay, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=js])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
retentionDays doesn't exist anymore, we can remove it from https://dxr.mozilla.org/mozilla-central/rev/aa3e49299a3aa5cb0db570532e3df9e75d30c2d1/toolkit/components/crashes/CrashManager.jsm#657.
|
||
Updated•8 years ago
|
Blocks: 1201022
Mentor: gfritzsche, alessio.placitelli
Priority: -- → P3
Whiteboard: [measurement:client][lang=js]
Attachment #8829338 -
Attachment is patch: false
|
|
||
Comment 2•8 years ago
|
||
Hi Kevin, welcome and thanks for picking this bug!
Do you need any help with this bug? I noticed you attached the CrashManager.jsm file updated with the requested changes. Unfortunately, we need a patch file in order to check in your changes.
If you don't know how to generate a patch file, please see here: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Do not hesitate to ask if you have questions!
Flags: needinfo?(kevin.gay)
Attachment #8829338 -
Attachment is obsolete: true
|
|
||
Updated•8 years ago
|
Assignee: nobody → kevin.gay
Status: NEW → ASSIGNED
Points: --- → 1
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8829397 [details] [diff] [review]
CrashManager.jsm.patch
Review of attachment 8829397 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good Kevin, thank you for the patch!
Attachment #8829397 -
Flags: review+
|
|
||
Comment 5•8 years ago
|
||
This is simple enough to not require a push to try (we're removing a leftover argument that's not used anymore). It works locally.
Flags: needinfo?(kevin.gay)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/406caf9e8cfa
Remove 'retentionDays' from sendTelemetryPing call in CrashManager.jsm. r=Dexter
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•