Tomer Cohen :tomer Assignee
	Description • 8 years ago

Most locales contains window rule with default font deceleration in the intl.css. This rule is obsolete and seems to be replaced with another rule under global.css. I'd suggest considering removing the rule from all intl.css files. 

As an added-value, since this is the only rule in intl.css for most locales, removing this rule from all locales will make the file empty for all affected locales.

default en-us intl.css file:
>   window { 
>     font: 3mm tahoma,arial,helvetica,sans-serif;
>   }
source: https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/locales/en-US/chrome/global/intl.css

global.css file:
>    window, page, dialog, wizard, prefwindow {
>      -moz-appearance: window;
>      background-color: -moz-Dialog;
>      color: -moz-DialogText;
>      font: message-box;
>    }
source: https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/themes/linux/global/global.css#46-55

	Tomer Cohen :tomer Assignee
	Comment 2 • 8 years ago

(In reply to Tomer Cohen :tomer from comment #0)
> source:
> https://dxr.mozilla.org/mozilla-central/rev/
> 3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/themes/linux/global/global.
> css#46-55

Windows source: 
https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/themes/windows/global/global.css#34-43

osx source:
https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/themes/osx/global/global.css#28-37

	Axel Hecht [:Pike]
	Comment 3 • 8 years ago

Triggered a try build, I want to see tests pass first.

	Axel Hecht [:Pike]
	Comment 4 • 8 years ago

Tomer, can you rebase your patch on top of a mozilla-central changeset so that try runs all builds successfully? The current one has only limited platform coverage due to another bug unrelated to this one.

It'd also help to see if there are other bugs in your queue this bug depends on.

	Axel Hecht [:Pike]
	Comment 5 • 8 years ago

Not happy with the results on https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d982c70bc1e98911c744a8fd913d4f00bfd7f1a&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=71977367.

Can you push to try once more with "try: -b o -p all -u all -t none" ? I don't think we need rebasing again, though, the base revision doesn't have the test failures we see on try.

My suspicion is that the test package isn't complete, and that breaks some of the tests.

Also, update the push to reviewboard with the rebased version?

	Tomer Cohen :tomer Assignee
	Comment 6 • 8 years ago

(In reply to Axel Hecht [:Pike] from comment #5)
> Can you push to try once more with "try: -b o -p all -u all -t none" ? I
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b50e9c522bf395b46b801776cd3b9e38b1087499

	Axel Hecht [:Pike]
	Comment 8 • 8 years ago
mozreview-review

Comment on attachment 8829099 [details]
Bug 1332832 - [intl.css] removal of the font settings from window rule

https://reviewboard.mozilla.org/r/106290/#review109630

try looks green (enough), r=me.

	Tomer Cohen :tomer Assignee
	Comment 9 • 8 years ago

(In reply to Axel Hecht [:Pike] from comment #8)
> Bug 1332832 - [intl.css] removal of the font settings from window rule
> try looks green (enough), r=me.

Do you think we should expand this to more locales? I've not noticed any side effects.

	Axel Hecht [:Pike]
	Comment 10 • 8 years ago

Yes, I think that's a good idea. Thanks for driving this.

	Axel Hecht [:Pike]
	Comment 11 • 7 years ago

Tomer, what are the next steps here? Do we need to still land the patch?

	Tomer Cohen :tomer Assignee
	Comment 12 • 7 years ago

(In reply to Axel Hecht [:Pike] from comment #11)
> Tomer, what are the next steps here? Do we need to still land the patch?

I've executed a test build against this patch. I got few errors and unsure if it is okay. How do you suggest to proceed? 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46b3947097733b8654667b0cbea8dd462759981d&selectedJob=113052478