Open
Bug 1332943
Opened 8 years ago
Updated 2 years ago
Dimmed highlighting UI persists even after findbar is closed, if you've navigated forward & back
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: dholbert, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
video/ogg
|
Details |
STR:
[Give yourself some forward/back history]:
1. Visit https://pastebin.mozilla.org/
2. Click View Help
3. Navigate back (via Firefox UI or alt+leftarrow)
[Activate findbar, and navigate to trigger bug]
4. Ctrl+F and type "syntax"
--> page dims
5. Alt+rightarrow to go forward.
6. Alt+leftarrow to go back.
7. Press "esc" (or click x on findbar) to close findbar
ACTUAL RESULTS:
Findbar disappears, but dimmed overlay + highlighting stick around!
EXPECTED RESULTS:
Findbar should disappear, AND the dimmed overlay + highlighting should disappear.
I think this likely reproduces anywhere -- I'm just using pastebin as a trivial example page.
Reporter | ||
Comment 1•8 years ago
|
||
Here's a screencast of the bug, with Nightly and a fresh profile.
As shown in the video, the first time I did STR step 6 (navigating forward+back with findbar open), I got different results (around 6 seconds in the video) -- there was no dimming or highlighting when I landed back on the initial page. But then I repeated steps 4-7 (using Ctrl+G to do "find next") and triggered the bug that time.
Comment 2•8 years ago
|
||
Impossible to reproduce on OSX. This'll only be possible on Windows & Linux, because keyboard shortcuts are the only way to trigger this race condition.
Comment 3•8 years ago
|
||
Ehsan, I think you might be the right person to ask this: I am calling `document.removeAnonymousContent(anonNode)` correctly each time the active document unloads, but somehow, after navigating forward and backward, the call does not do anything anymore.
More exact STR:
[Give yourself some forward/back history]:
1. Visit https://pastebin.mozilla.org/
2. Click View Help
3. Navigate back (via Firefox UI or alt+leftarrow)
[Activate findbar, and navigate to trigger bug]
4. Ctrl+F and type "syntax"
--> page dims
5. Alt+rightarrow to go forward.
6. Alt+leftarrow to go back.
[Notice that highlight is gone]
7. Hit Enter or Ctrl+G to activate highlight again
--> page dims
8. Alt+rightarrow to go forward.
9. Alt+leftarrow to go back.
[Notice that the highlight is STILL there]
It seems to me that `document.removeAnonymousContent(anonNode)` is unable to retrieve anonNode when it was inserted on a document from the bfcache?
Flags: needinfo?(ehsan)
Comment 4•8 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Ehsan, I think you might be the right person to ask this: I am calling
> `document.removeAnonymousContent(anonNode)` correctly each time the active
> document unloads, but somehow, after navigating forward and backward, the
> call does not do anything anymore.
>
> More exact STR:
> [Give yourself some forward/back history]:
> 1. Visit https://pastebin.mozilla.org/
> 2. Click View Help
> 3. Navigate back (via Firefox UI or alt+leftarrow)
> [Activate findbar, and navigate to trigger bug]
> 4. Ctrl+F and type "syntax"
> --> page dims
> 5. Alt+rightarrow to go forward.
> 6. Alt+leftarrow to go back.
> [Notice that highlight is gone]
> 7. Hit Enter or Ctrl+G to activate highlight again
> --> page dims
> 8. Alt+rightarrow to go forward.
> 9. Alt+leftarrow to go back.
> [Notice that the highlight is STILL there]
I can't test unfortunately since I'm on OSX.
> It seems to me that `document.removeAnonymousContent(anonNode)` is unable to
> retrieve anonNode when it was inserted on a document from the bfcache?
Since I don't know exactly when removeAnonymousContent is called, I can't answer your question accurately. If the document is already in the bfcache, then I think the call to GetCanvasFrame() in the beginning of RemoveAnonymousContent() will return null. But there's no point in guessing. Can you set a breakpoint on nsIDocument::RemoveAnonymousContent() and see what happens there?
Flags: needinfo?(ehsan)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•