There are lots of SPS references still in the codebase. Let's change them to "the Gecko Profiler".

glandium, I'm requesting co-review from you because this touches build system files.

They are all in comments.

Shu, apologies for the monumentally boring patch.

After these patches, the only notable use of SPS left in the codebase is for the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do in a separate bug.

(In reply to Nicholas Nethercote [:njn] from comment #7) > After these patches, the only notable use of SPS left in the codebase is for > the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do > in a separate bug. I also see sps_profiler_define / sps_profiler in toolkit/moz.configure. And the "--spsProfile*" command line flags in talos.py; changing those would also require updating the try syntax builder and some documentation on MDN.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1b2dbf2f143a69865b59632bbf6c303b929d50 Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/205707751e6e5b68b72dfa6fafb4bf7ab8e2f49b Bug 1333296 (part 2) - Change "SPS:" mentions in logging code. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/cc24014e56e979110b15952a2da6b11233a1384f Bug 1333296 (part 3) - Remove SPS mentions in tools/profiler. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/c785789f0dd92065a81418b983a28171a7cfe171 Bug 1333296 (part 4) - Remove SPS references in testing/talos/. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/a085cb9e5f0ceb5ae09b91ab1bc11706bea0c96e Bug 1333296 (part 5) - Remove SPS references in devtools/ and dom/. r=mstange.

> I also see sps_profiler_define / sps_profiler in toolkit/moz.configure. Thanks. I changed these in part 7, and I found a few more similar ones, which are in part 8. > And the "--spsProfile*" command line flags in talos.py; changing those would > also require updating the try syntax builder and some documentation on MDN. Looks like we have three: * --spsProfile * --spsProfileInterval * --spsProfileEntries I will leave these unchanged for now because I don't want to coordinate updates to multiple repos.

https://hg.mozilla.org/mozilla-central/rev/8a1b2dbf2f14 https://hg.mozilla.org/mozilla-central/rev/205707751e6e https://hg.mozilla.org/mozilla-central/rev/cc24014e56e9 https://hg.mozilla.org/mozilla-central/rev/c785789f0dd9 https://hg.mozilla.org/mozilla-central/rev/a085cb9e5f0c

Comment on attachment 8829730 [details] [diff] [review] (part 6) - Remove SPS references in js/ Review of attachment 8829730 [details] [diff] [review]: ----------------------------------------------------------------- I confess I only skimmed through the renamings, but it looks perfectly reasonable. Thanks for the detailed commit message.

https://hg.mozilla.org/integration/mozilla-inbound/rev/09841bae5cafa6700994f363621e58e2e8d6c355 Bug 1333296 (part 6) - Remove SPS references in js/. r=shu. https://hg.mozilla.org/integration/mozilla-inbound/rev/9a606c3f83b22face35bcd70b4536066ff75eb3b Bug 1333296 (part 7) - Remove SPS references in tookit/moz.configure. r=glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2b14111392bd1f1e2a11c9d002793b2e9f50d8 Bug 1333296 (part 8) - Remove more SPS references. r=mstange.

https://hg.mozilla.org/mozilla-central/rev/09841bae5caf https://hg.mozilla.org/mozilla-central/rev/9a606c3f83b2 https://hg.mozilla.org/mozilla-central/rev/4d2b14111392