Closed Bug 1333305 Opened 8 years ago Closed 8 years ago

Permafailing browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 11 items. - Got 12, expected 11 on aurora 53

Categories

(Firefox :: Toolbars and Customization, defect)

53 Branch
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: philor, Assigned: Gijs)

References

Details

Attachments

(1 file)

One of three things keeping aurora closed after the merge. My best wild guess so far, after I was told that the webide button (visible in the screenshot) puts itself in the toolbar when the feature is used, but is not a new thing in this version of aurora, is that the bustage is that this is the first time on aurora that we've had a webide-using test which runs in the same chunk of browser-chrome as browser_880382_drag_wide_widgets_in_panel.js and before it runs. https://treeherder.mozilla.org/logviewer.html#?job_id=71230808&repo=mozilla-aurora 17:43:35 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 11 items. - Got 12, expected 11 17:43:35 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 10 items. - Got 11, expected 10 17:43:36 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 10 items. - Got 11, expected 10 17:43:36 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 10 items. - Got 11, expected 10 17:43:36 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Area PanelUI-contents should have 11 items. - Got 12, expected 11 17:43:36 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js | Item 10 in PanelUI-contents should match expectations. - Got edit-controls, expected email-link-button
gijs, mike, could you take a look at this, its one of the tree closing reasons for aurora, thanks!
Flags: needinfo?(miket)
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1324062
Status: NEW → ASSIGNED
Flags: needinfo?(miket)
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8829798 [details] Bug 1333305 - fix perma-orange by only removing buttons if they're present (splice(-1, 1) removes the last element of an array), https://reviewboard.mozilla.org/r/106790/#review107816
Attachment #8829798 - Flags: review?(mdeboer) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8c5ec728bfd0 fix perma-orange by only removing buttons if they're present (splice(-1, 1) removes the last element of an array), r=mikedeboer
Thanks, sorry about that.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: