Marco Zehe (:MarcoZ) Reporter
	Description • 8 years ago

+++ This bug was initially created as a clone of Bug #1327946 +++

The panel that opens when hitting the site identity button doesn't read well with screen readers. The following problems are found:

1. The focus lands nowhere specific.
2. Buttons such as the one to expand on the identity has no label, but can be tabbed to. It needs alternative text if it is a graphical button.
3. This panel, before the rewrite, used to read automatically, but now doesn't.
4. All the text snippets are just plain text snippets which are hard to review. Suggestion: Make these tabable by putting the relevant information into a textarea and giving them a label. That way, info can also be easily copied and pasted.

	Johann Hofmann [:johannh]
	Comment 1 • 8 years ago

Thanks for reporting this. We should improve on that. A couple of questions:
 
> 1. The focus lands nowhere specific.

I thought that's always the case when popup panels are autofocused. Is this a big issue considering you can continue tabbing to a relevant element?

> 3. This panel, before the rewrite, used to read automatically, but now
> doesn't.

Do you have any pointers to attributes/elements that are required for that to happen?

> 4. All the text snippets are just plain text snippets which are hard to
> review. Suggestion: Make these tabable by putting the relevant information
> into a textarea and giving them a label. That way, info can also be easily
> copied and pasted.

Pardon my ignorance, but I was under the impression that making too many non-actionable elements tabable isn't great either. Would this be improved by fixing problem 3?

	:Gijs (he/him)
	Comment 2 • 8 years ago

(In reply to Johann Hofmann [:johannh] from comment #1)
> > 3. This panel, before the rewrite, used to read automatically, but now
> > doesn't.
> 
> Do you have any pointers to attributes/elements that are required for that
> to happen?

probably role=alert if you're not using that already.

	Johann Hofmann [:johannh]
	Comment 3 • 8 years ago

We should consider splitting this bug up into actionable and more easily upliftable pieces.

	Marco Zehe (:MarcoZ) Reporter
	Comment 4 • 8 years ago

(In reply to Johann Hofmann [:johannh] from comment #3)
> We should consider splitting this bug up into actionable and more easily
> upliftable pieces.

Agreed, turning this one into a meta bug.

	Marco Zehe (:MarcoZ) Reporter
	Comment 5 • 8 years ago

I've now filed bugs for the first three issues. Issue 4 from my original description might be solved by issue 3, or we might need some additional work. I am especially worried about the stuff that gets shown and hidden by the site-security-info-expander button. As far as I can see, it gets added to the end of the DOM, but not really sure.

	Johann Hofmann [:johannh]
	Comment 6 • 8 years ago

Thanks, we'll hopefully get around to discussing these at triage today!

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 8 years ago

What's the status of this bug with respect to Fx52? We've only got a couple weeks left of real development time for it in this cycle.

	Johann Hofmann [:johannh]
	Comment 8 • 8 years ago

TBH it's unlikely that we will get any of this into 52. Bug 1335018 maybe, I'll look into that in the next days. Bug 1334496 only needs to get to 53. Bug 1335016 will need a label. The rest are not recent regressions, but we would still like to solve them in a timely manner (hence the P2). 53 sounds like a more likely target for those.

	Johann Hofmann [:johannh]
	Comment 9 • 8 years ago

To clarify the ESR status of dependencies: I found that we should indeed track bug 1335737 for 52. I'll put that one on P1 and try to resolve it ASAP. The other bugs are either not affecting 52 or have already been in 45. It would be nice to fix some of them but we're not breaking ESR by not solving those.

	Johann Hofmann [:johannh]
	Comment 10 • 7 years ago

Marking this as fixed for 52 since we solved bug 1335737 by fixing and uplifting bug 1335018 (yes, it's a bit complicated, sorry).

	Johann Hofmann [:johannh]
	Comment 11 • 7 years ago

All dependencies are resolved so I'm marking this fixed.