Closed
Bug 133351
Opened 23 years ago
Closed 23 years ago
Bookmarks cannot be moved by drag in sidebar
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: mozbug, Assigned: janv)
References
Details
(Keywords: regression, Whiteboard: [adt2] fixed on the branch)
Attachments
(1 file)
(deleted),
patch
|
mikepinkerton
:
review+
jag+mozilla
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
2002032503 win98 trunk
2002032500 linux cvs trunk
Pick a bookmark in the sidebar.
Move it by dragging it.
Expected result: bookmark is moved.
Actual result: bookmark is not moved and insertion line stays shown.
This is working in the bookmark management window, not in the sidebar.
2002031503 win98 build is ok
2002031608 win 98 build is not ok.
Comment 1•23 years ago
|
||
*** This bug has been marked as a duplicate of 128461 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•23 years ago
|
||
I'm not sure this is a dup.
I have no problems in the manage bookmark window nor have I problem to delete or
edit bookmark in both the sidebar and the bookmark manage window.
Comment 3•23 years ago
|
||
reopening, this is not a dup of 128461
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•23 years ago
|
Comment 4•23 years ago
|
||
nsbeta1+ per Nav triage team, ->1.0, nav2
Comment 5•23 years ago
|
||
This issue has already been reported in bug 131547 and has been duped against
bug 128461.
Anyway, this bug has been plussed, I will dupe 132547 against this one.
Comment 6•23 years ago
|
||
*** Bug 131547 has been marked as a duplicate of this bug. ***
Comment 7•23 years ago
|
||
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.) Thanks!
Comment 9•23 years ago
|
||
*** Bug 138175 has been marked as a duplicate of this bug. ***
Comment 10•23 years ago
|
||
*** Bug 139419 has been marked as a duplicate of this bug. ***
Comment 11•23 years ago
|
||
confirming on RC1 (2002041711) / Win2K, including the fact that it's a problem
in the sidebar but not the bookmark management window.
Comment 12•23 years ago
|
||
*** Bug 139501 has been marked as a duplicate of this bug. ***
Comment 13•23 years ago
|
||
*** Bug 139951 has been marked as a duplicate of this bug. ***
Comment 14•23 years ago
|
||
confirming on RC1 (2002042406) / Win98,
problem occurs in sidebar but not the bookmark management window
Comment 15•23 years ago
|
||
Confirming I see this on OpenVMS build from 20020419
Comment 16•23 years ago
|
||
Also, IF it works, in many cases the Link is not added where the position bar is
shown, but somewhere completely different. This is also in the sidebar only.
Assignee | ||
Comment 17•23 years ago
|
||
I wonder why it works even in sidebar when I temporally (while in a drag session
) hover with mouse to other window (onDragExit and onDragEnter is called).
This might be a widget DND issue.
Assignee | ||
Comment 19•23 years ago
|
||
I think this regressed after the nsContentAreaDragDrop rewrite.
nsContentAreadDragDrop is listening to drag events and since sidebar is part of
the document which this nsContentAreaDragDrop listens to, it was overriding
canDrop value.
So this patch prevents default dragOver event in nsTreeBodyFrame::OnDragOver
Comment 20•23 years ago
|
||
Comment on attachment 82422 [details] [diff] [review]
proposed fix
looks good. r=pink
Attachment #82422 -
Flags: review+
Comment 21•23 years ago
|
||
Comment on attachment 82422 [details] [diff] [review]
proposed fix
sr=jag
Attachment #82422 -
Flags: superreview+
Assignee | ||
Comment 22•23 years ago
|
||
landed on the trunk
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 23•23 years ago
|
||
Comment on attachment 82422 [details] [diff] [review]
proposed fix
a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #82422 -
Flags: approval+
Updated•23 years ago
|
Whiteboard: [adt2] → [adt2] fixed on the branch
Comment 25•23 years ago
|
||
I still see this problem on OpenVMS build 20020513 (rc2)
Comment 26•22 years ago
|
||
vrfy'd fixed with 2003.02.19 comm trunk on linux rh8.0.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•