Closed Bug 1333645 Opened 8 years ago Closed 8 years ago

Remove the VS2013 MaxILKSize workaround

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file)

patch
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
VS2013 is no longer a supported compiler for our codebase.
Attached patch patch (deleted) — — Splinter Review
Assignee: nobody → dmajor
Attachment #8830118 - Flags: review?(mh+mozilla)
Depends on: 1133384
No longer depends on: 1186064
Depends on: 1186064
Comment on attachment 8830118 [details] [diff] [review] patch Review of attachment 8830118 [details] [diff] [review]: ----------------------------------------------------------------- ::: old-configure.in @@ -1137,5 @@ > - dnl See https://connect.microsoft.com/VisualStudio/feedback/details/1044914/fatal-error-lnk1248 > - LDFLAGS="$LDFLAGS -MaxILKSize:0x7FF00000" > - fi > - dnl Minimum reqiurement of Gecko is VS2010 or later which supports > - dnl both SSSE3 and SSE4.1. It would be better to keep this comment but change VS2010 to 2015. Same for AVX2 below.
Attachment #8830118 - Flags: review?(mh+mozilla) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b2c4e4641643 Remove the VS2013 MaxILKSize workaround. r=glandium
https://hg.mozilla.org/mozilla-central/rev/b2c4e4641643
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: