Closed
Bug 1333685
Opened 8 years ago
Closed 8 years ago
Eliminate code duplication between circle and ellipse shape constructor
Categories
(Core :: Layout: Floats, defect)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
We might be able to share more code between the circle and ellipse shape constructor per Bug 1326406 comment 22, and even just use the ellipse class for circles per Bug 1326406 comment 11.
| Comment hidden (obsolete) |
|
Assignee | |
Comment 2•8 years ago
|
||
The difference between CircleShapeInfo's constructor and EllipseShapeInfo's
is the computation of the radii. Therefore, this patch creates a factory
function to for that so that shape-outside: circle() could be implemented by
using EllipseShapeInfo.
MozReview-Commit-ID: 9ZBQu8zCSrM
Attachment #8830200 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8830192 -
Attachment is obsolete: true
Attachment #8830192 -
Flags: review?(dbaron)
|
||
Updated•8 years ago
|
Attachment #8830200 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a79202aaab99
Eliminate CircleShapeInfo, and use EllipseShapeInfo for circle(). r=dbaron
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•