Closed
Bug 1333746
Opened 8 years ago
Closed 8 years ago
Tooltip background color is dark, making text unreadable
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1319353
People
(Reporter: LpSolit, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
image/png
|
Details |
I updated Firefox on Linux from 50.1.0 to 51.0 last night, and now all tootips use a dark background color, making the text in the tooltips unreadable, see the screenshot.
Comment 1•8 years ago
|
||
What GTK theme is this? Any chance you can find when exactly this broke? I suspect this is a GTK widget bug...
Keywords: regressionwindow-wanted
Reporter | ||
Comment 2•8 years ago
|
||
"gsettings get org.gnome.desktop.interface gtk-theme" returns 'Adwaita'.
No idea when it broke exactly. I updated from 50.1.0 to 51.0 directly. I didn't install any beta.
Comment 3•8 years ago
|
||
(In reply to Frédéric Buclin from comment #2)
> "gsettings get org.gnome.desktop.interface gtk-theme" returns 'Adwaita'.
>
> No idea when it broke exactly. I updated from 50.1.0 to 51.0 directly. I
> didn't install any beta.
OK, would you be able to run mozregression to figure it out? ( http://mozilla.github.io/mozregression/ )
From the commandline something like:
mozregression --good 50 --bad 51
should get you a pushlog on mozilla-central fairly quickly.
Reporter | ||
Comment 4•8 years ago
|
||
beta3 (20161124073320) is fine, beta4 (20161128075558) is not.
Comment 5•8 years ago
|
||
According to comment#4, regression window is
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=f37e99ebc6e0c682003b52573f415e5fd78d425a&tochange=1b954c82dd04faf1926804d89c0d130dc6b9ab93
Suspect : bug 1315668
(btw, i cannot reproduce on ubuntu16.04)
Blocks: 1315668
Updated•8 years ago
|
Keywords: regressionwindow-wanted
OS: Unspecified → Linux
Comment 6•8 years ago
|
||
Thanks Alice. Looks like Karl is out. Martin, can you take a look as you reviewed the patch?
Component: Theme → Widget: Gtk
Flags: needinfo?(stransky)
Product: Firefox → Core
Updated•8 years ago
|
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
Comment 7•8 years ago
|
||
(In reply to :Gijs from comment #6)
> Thanks Alice. Looks like Karl is out. Martin, can you take a look as you
> reviewed the patch?
Sure. Which system/theme is that? Any Ubuntu or so? Thanks.
Flags: needinfo?(stransky) → needinfo?(alice0775)
Comment 8•8 years ago
|
||
[Tracking Requested - why for this release]: These fixes were uplifted and so they affect 51 and 52. We should ideally fix for 52.
(In reply to Martin Stránský from comment #7)
> (In reply to :Gijs from comment #6)
> > Thanks Alice. Looks like Karl is out. Martin, can you take a look as you
> > reviewed the patch?
>
> Sure. Which system/theme is that? Any Ubuntu or so? Thanks.
Alice couldn't reproduce on Ubuntu (comment #5). Hopefully Frédéric can provide more specific info here (but it seems we can't needinfo them).
tracking-firefox52:
--- → ?
Flags: needinfo?(alice0775)
Reporter | ||
Comment 9•8 years ago
|
||
I'm using Mageia 5, KDE, theme Adwaita + Firefox 51.0.1 64-bit.
Comment 10•8 years ago
|
||
(In reply to Frédéric Buclin from comment #9)
> I'm using Mageia 5, KDE, theme Adwaita + Firefox 51.0.1 64-bit.
Thanks. Which gtk3 version there?
Reporter | ||
Comment 11•8 years ago
|
||
(In reply to Martin Stránský from comment #10)
> Thanks. Which gtk3 version there?
3.14.8
Comment 13•8 years ago
|
||
Yes, I can reproduce that on KDE + Gtk 3.14.15 (Fedora 21). Seems to be KDE only.
Comment 14•8 years ago
|
||
The bug is already fixed in trunk (54/53). I'll use mozregression to find exact commit which fixes that.
Comment 15•8 years ago
|
||
This is a dupe of Bug 1319353 which fixes that.
Fixed in 52 in the duplicate.
You need to log in
before you can comment on or make changes to this bug.
Description
•