Closed Bug 1334140 Opened 7 years ago Closed 7 years ago

[e10s] Pasting using Cmd-V results in two consecutive pastes

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- verified

People

(Reporter: mconley, Assigned: spohl)

References

Details

(Keywords: regression) 

STR:

1) Copy this string to the clipboard "This should only appear once"
2) Open a new tab to data:text/html,<html contenteditable>
3) Select the white background, and use Cmd-V to paste the string from step 1 into the editable area.

ER:

A single instance of the string from step 1.

AR:

The string is pasted twice.

I bisected this - this is a regression from bug 429824.
Keywords: regression
Looking into it. Thanks for reporting!
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Looks like this is e10s-only.
Summary: Pasting using Cmd-V results in two consecutive pastes → [e10s] Pasting using Cmd-V results in two consecutive pastes
There is a difference between e10s and non-e10s deep within PresShell::HandleEvent here, which causes mTextInputHandler->HandleKeyDownEvent(theEvent)[1] to report that the event hasn't been handled when in fact it has. Even though I'm making progress I don't expect to have this fixed by EOD today. I've backed out bug 429824 since pasting via cmd+v is pretty fundamental functionality.

[1] https://dxr.mozilla.org/mozilla-central/rev/d92fd6b6d6bfc5b566222ae2957e55772d60151a/widget/cocoa/nsChildView.mm#5474
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox54: affected → fixed
Target Milestone: --- → mozilla54
Flags: qe-verify+
Reproduced the issue using STR from comment 0.
This is verified fixed on 54 beta 4 under Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Flags: qe-verify+

I see that it is listed as "fixed" by some users but I don't see what the 'fix' was. Please advise.

(In reply to William Howe from comment #9)

I see that it is listed as "fixed" by some users but I don't see what the 'fix' was. Please advise.

From comment 4, it looks like it was fixed by backing out the patch that caused the issue in the first place. If you are experiencing a similar issue, you should file a new bug please.

You need to log in before you can comment on or make changes to this bug.