Julian Descottes [:jdescottes] Assignee
	Description • 8 years ago

Follow up to Bug 1333602. We messed up L10n for the devtools debugger.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1333602#c10

The goal of this bug is to revert the latest changes of debugger.properties.

	Francesco Lodolo [:flod]
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8830764 [details]
Bug 1334154 - revert debugger.properties changes from last update;

https://reviewboard.mozilla.org/r/107492/#review108628

Thanks, this should revert everything we need to revert.

	Julian Descottes [:jdescottes] Assignee
	Comment 3 • 8 years ago

Thanks for the review flod! 
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2706c3de397a938c13d1f09f339de04a356fabea

(green for now)

	Pulsebot
	Comment 4 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9ef1dae0826
revert debugger.properties changes from last update;r=flod

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c9ef1dae0826

	Stefan Plewako [:stef]
	Comment 6 • 8 years ago

(In reply to Wes Kocher (:KWierso) from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/c9ef1dae0826

Please don't commit changes with misleading descriptions. You are creating even greater mess and waste other people time even more.

	Francesco Lodolo [:flod]
	Comment 7 • 8 years ago

(In reply to Stefan Plewako [:stef] from comment #6)
> Please don't commit changes with misleading descriptions. You are creating
> even greater mess and waste other people time even more.

This is reverting all the string changes introduced in (minus 2 new strings)
https://hg.mozilla.org/mozilla-central/diff/fe88899da4aa/devtools/client/locales/en-US/debugger.properties

The commit message doesn't (and didn't) seem misleading to me.

	Stefan Plewako [:stef]
	Comment 8 • 8 years ago

(In reply to Francesco Lodolo [:flod] from comment #7)
> This is reverting all the string changes introduced in (minus 2 new strings)
> https://hg.mozilla.org/mozilla-central/diff/fe88899da4aa/devtools/client/
> locales/en-US/debugger.properties
> 
> The commit message doesn't (and didn't) seem misleading to me.

It is highly misleading as the commit isn't reverting the earlier changes and the commit message doesn't mention 2 new string.