Closed
Bug 1334227
Opened 8 years ago
Closed 8 years ago
Crash [@ nsFloatManager::FloatInfo::FloatInfo ]
Categories
(Core :: Layout: Floats, defect)
Tracking
()
VERIFIED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | verified |
People
(Reporter: sebo, Assigned: TYLin)
References
(Blocks 1 open bug, )
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
With the changes of bug 1326406 Firefox crashes on https://css-tricks.com/almanac/properties/s/shape-outside/. See this crash report:
https://crash-stats.mozilla.com/report/index/fc698b6f-5239-4f86-8f16-e2ef42170126
Sebastian
Comment 1•8 years ago
|
||
Presumably mShapeInfo is null because we hit one of the types that we parse but don't yet implement?
Given that this feature is pref'd off, even on nightly, I don't think this is a big deal. I think this should go away once all the types are implemented.
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to David Baron :dbaron: ⌚️UTC-8 from comment #1)
> Presumably mShapeInfo is null because we hit one of the types that we parse
> but don't yet implement?
You're right. It's crashing when using the polygon() or the inset() function. Test case:
data:text/html,<div style="shape-outside:polygon(0 0, 0 200px, 300px 600px);float:left;"></div>
Sebastian
Updated•8 years ago
|
Crash Signature: [@ nsFloatManager::FloatInfo::FloatInfo ]
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8832776 [details]
Bug 1334227 - Early return in unimplemented shape-outside cases.
https://reviewboard.mozilla.org/r/109042/#review110178
::: layout/generic/nsFloatManager.cpp:721
(Diff revision 1)
> + // XXX: Remove this null check once all the shape-outside values are
> + // implemented.
> + if (!mShapeInfo) {
> + return;
> + }
I'd prefer you leave the assertion here, and early return in the two unimplemented cases.
Attachment #8832776 -
Flags: review?(xidorn+moz)
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8832776 [details]
Bug 1334227 - Early return in unimplemented shape-outside cases.
https://reviewboard.mozilla.org/r/109042/#review110182
Attachment #8832776 -
Flags: review?(xidorn+moz) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abc3cb8fff3e
Early return in unimplemented shape-outside cases. r=xidorn
Assignee | ||
Comment 8•8 years ago
|
||
xidorn, thank you for the review.
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•8 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Reporter | ||
Comment 10•8 years ago
|
||
Works with Nightly 2017-02-03, thanks for the fast fix!
Sebastian
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•