Closed Bug 1334358 Opened 8 years ago Closed 8 years ago

Remove nsCSSFrameConstructor::CreateAnonymousFrames

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part 2 - Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Followup refactoring suggested in bug 1334247. The goal here is to send more things through AddFCItemsForAnonymousContent, since that's what we're going to hook with our style context resolution behavior in bug 1331322.
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2) > And here's the rest: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=71bdd8be07b1ed04a2672dd9378826e4d8b85287 Looks green.
Comment on attachment 8831010 [details] [diff] [review] Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1 >+ AutoTArray<nsIAnonymousContentCreator::ContentInfo, 1> newAnonymousItems; s/1/2/, right? Because we expect it to produce two things... r=me
Attachment #8831010 - Flags: review?(bzbarsky) → review+
Comment on attachment 8831011 [details] [diff] [review] Part 2 - Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. v1 r=me
Attachment #8831011 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #6) > Comment on attachment 8831010 [details] [diff] [review] > Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1 > > >+ AutoTArray<nsIAnonymousContentCreator::ContentInfo, 1> newAnonymousItems; > > s/1/2/, right? Because we expect it to produce two things... Good catch! That was a holdover from a previous version of the patch where I altered CreateAnonymousContent to not return that item, instead of manually removing it at the caller.
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1a21a22c12b Stop using CreateAnonymousFrames for combo box creation. r=bz https://hg.mozilla.org/integration/mozilla-inbound/rev/314707aa7875 Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. r=bz
https://hg.mozilla.org/mozilla-central/rev/f1a21a22c12b https://hg.mozilla.org/mozilla-central/rev/314707aa7875
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: