Closed
Bug 1334401
Opened 8 years ago
Closed 8 years ago
Prefer docker images from higher levels
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla54
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8831058 [details]
Bug 1334401 - Prefer docker images from higher levels.
https://reviewboard.mozilla.org/r/107720/#review109102
Nice fix!
Background:
The hash we index under is the hash of the dockerfile + files copied into the image.
So there is no guarantee that the image indexed for that hash is a result of this dockerfile + files copied,
other than the fact that if it was index under level 3, the creator had 3 credentials.
Hence, we can always trust higher levels, but not lower levels.
Extra benefit of prefering the high level is that:
A) try user can't poison other try users (if a high commit level image build already exists)
B) few docker images will have to be cached on the workers, more disk space for caching other things
Attachment #8831058 -
Flags: review?(jopsen) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/761ae4db38f4
Prefer docker images from higher levels. r=jonasfj
|
||
Comment 4•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/fd57fca9a8f1 for surprising test_taskgraph.py, https://treeherder.mozilla.org/logviewer.html#?job_id=72789037&repo=autoland
| Comment hidden (mozreview-request) |
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/0fe00456f943
Prefer docker images from higher levels. r=jonasfj
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•