Right now we don't propagate those flags so sometimes we load from cache when we shouldn't.

I'm not quite sure how I'd go about testing this. I did some manual testing, however, and it seemed to work OK. MozReview-Commit-ID: ESfCqSc0BJK

Comment on attachment 8831242 [details] [diff] [review] Propagate reload flags when reloading pages with Large-Allocation headers >+ // Get the channel's load flags, and use them to generate docshell load flags. >+ // We want to make sure to propagate the refresh and cache busting flags. >+ nsLoadFlags channelLoadFlags; >+ aChannel->GetLoadFlags(&channelLoadFlags); >+ >+ uint32_t docshellLoadFlags = nsIWebNavigation::LOAD_FLAGS_NONE; >+ if (channelLoadFlags & nsIRequest::LOAD_BYPASS_CACHE) { >+ docshellLoadFlags |= nsIWebNavigation::LOAD_FLAGS_BYPASS_CACHE; >+ docshellLoadFlags |= nsIWebNavigation::LOAD_FLAGS_BYPASS_PROXY; >+ } else if (channelLoadFlags & nsIRequest::VALIDATE_ALWAYS) { >+ docshellLoadFlags |= nsIWebNavigation::LOAD_FLAGS_IS_REFRESH; >+ } >+ So you aren't sending docshellLoadFlags but nsIWebNavigation flags, so rename the variable. docshellLoadFlag is easy to mix with docshellLoadType http://searchfox.org/mozilla-central/source/docshell/base/nsDocShellLoadTypes.h Yes, this is confusing. And we have also nsIDocShellLoadInfo.

Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d025789972f Propagate reload flags when reloading pages with Large-Allocation headers, r=smaug

Comment on attachment 8831242 [details] [diff] [review] Propagate reload flags when reloading pages with Large-Allocation headers Approval Request Comment This is part 5 of a 6-bug/7-patch uplift request [Feature/Bug causing the regression]: We would like to ship the Large-Allocation header in 52/53, and these patches make some final touch-ups which will be required before we can ship. [User impact if declined]: Increased crash rates of wasm games on 32-bit windows [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Most of these fixups just landed in Nightly. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: bug 1331083 bug 1332343 bug 1334210 bug 1333936 bug 1334586 bug 1331087 [Is the change risky?]: Not very [Why is the change risky/not risky?]: This exposes and enables an opt-in low risk web API which is only supported by Firefox to help avoid OOM problems on 32-bit windows. [String changes made/needed]: A string was added to dom.properties in bug 1331087

Comment on attachment 8831242 [details] [diff] [review] Propagate reload flags when reloading pages with Large-Allocation headers Part of a larger uplift for aurora, since we can pref this off let's take it for 53.