Closed Bug 1334919 Opened 8 years ago Closed 4 years ago

Always restore the previously open bookmark folder when showing the home panels

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: JanH, Unassigned)

References

Details

Currently, we're only restoring the currently open folder in the bookmarks panel when we open the home panels by directly navigating to about:home (usually by going back in the tab history). Maybe we should instead always restore the previously open bookmarks folder, i.e. even when we're showing the home panels through - switching to a different tab that is already at about:home - clicking into the address bar We're already storing the folder stack information each time it changes (https://dxr.mozilla.org/mozilla-central/rev/e7b795db8b5b20c472d8070030e9b08c99a01db6/mobile/android/base/java/org/mozilla/gecko/home/BookmarksPanel.java#304), so it's just a matter of retrieving that info for the above cases as well. (In reply to Gary Sanders from bug 1332955 comment #7) > On Firefox Android version 50.1.0, I can confirm that the test described at > the top of this report works. However, the following test does not work > (perhaps it never worked, don't know). In any event, the open bookmarks > folder location is NOT remembered: > > [1] Open Firefox for Android and navigate to a bookmark sub folder. > [2] Open one of the links in the bookmark sub folder in a new tab. > [3] After the page loads in a new tab, click on the tab where the page has > loaded. > [4] Click on the tab from which the bookmarks were natigated to in step #1. > ==> The current bookmark folder location is forgotten and goes back to the > root bookmark folder level. I would expect Firefox to remember the bookmark > folder location. Alternative scenario: 1. Open a new tab, go to some bookmark subfolder and click a link. 2. When the page has loaded, *don't* go back, instead open the home panels by clicking into the address bar. Expected: The bookmark folder from step 1 is shown. Actual: The root folder is shown. This also overwrites the stored bookmarks folder position from step 1, so if you close the home panel and then go back after all, about:home will still not show the original folder, but instead whatever folder you had open at the end of step 2
*If* we decide to do this, then it might perhaps be nice if we could also remember the current scroll position of the list view.
(In reply to Jan Henning [:JanH] from comment #1) > *If* we decide to do this, then it might perhaps be nice if we could also > remember the current scroll position of the list view. +1 for that suggestion. That would be extremely useful.
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Status: REOPENED → NEW
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 6 years ago4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.