Xidorn Quan [:xidorn] UTC+11 Reporter
	Description • 8 years ago

layout/style/test/test_animations.html crashes with the fatal assertion:
Assertion failure: aRestyleHint == 0, at c:/mozilla-source/stylo/layout/base/ServoRestyleManager.cpp:53
#01: mozilla::RestyleManagerHandle::Ptr::PostRestyleEvent (c:\mozilla-source\stylo\obj-firefox-stylo\dist\include\mozilla\restylemanagerhandleinlines.h:49)
#02: nsIPresShell::RestyleForAnimation (c:\mozilla-source\stylo\layout\base\presshell.cpp:2988)
#03: mozilla::EffectCompositor::PostRestyleForAnimation (c:\mozilla-source\stylo\dom\animation\effectcompositor.cpp:319)
#04: mozilla::EffectCompositor::RequestRestyle (c:\mozilla-source\stylo\dom\animation\effectcompositor.cpp:274)
#05: mozilla::dom::Animation::PostUpdate (c:\mozilla-source\stylo\dom\animation\animation.cpp:1312)
#06: mozilla::dom::CSSAnimation::SetAnimationIndex (c:\mozilla-source\stylo\layout\style\nsanimationmanager.h:146)
#07: nsAnimationManager::BuildAnimations (c:\mozilla-source\stylo\layout\style\nsanimationmanager.cpp:1114)
#08: nsAnimationManager::UpdateAnimations (c:\mozilla-source\stylo\layout\style\nsanimationmanager.cpp:424)
#09: mozilla::ServoStyleSet::GetContext (c:\mozilla-source\stylo\layout\style\servostyleset.cpp:176)
#10: mozilla::ServoStyleSet::GetContext (c:\mozilla-source\stylo\layout\style\servostyleset.cpp:141)
#11: mozilla::ServoStyleSet::ResolveStyleFor (c:\mozilla-source\stylo\layout\style\servostyleset.cpp:188)
#12: mozilla::StyleSetHandle::Ptr::ResolveStyleFor (c:\mozilla-source\stylo\obj-firefox-stylo\dist\include\mozilla\stylesethandleinlines.h:95)
#13: nsCSSFrameConstructor::ResolveStyleContext (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:5014)
#14: nsCSSFrameConstructor::ResolveStyleContext (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:4984)
#15: nsCSSFrameConstructor::AddFrameConstructionItems (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:5632)
#16: nsCSSFrameConstructor::ContentAppended (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:7481)
#17: nsCSSFrameConstructor::CreateNeededFrames (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:7139)
#18: nsCSSFrameConstructor::CreateNeededFrames (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:7140)
#19: nsCSSFrameConstructor::CreateNeededFrames (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:7140)
#20: nsCSSFrameConstructor::CreateNeededFrames (c:\mozilla-source\stylo\layout\base\nscssframeconstructor.cpp:7158)
#21: mozilla::ServoRestyleManager::ProcessPendingRestyles (c:\mozilla-source\stylo\layout\base\servorestylemanager.cpp:344)
#22: mozilla::PresShell::FlushPendingNotifications (c:\mozilla-source\stylo\layout\base\presshell.cpp:4173)
#23: nsDocument::FlushPendingNotifications (c:\mozilla-source\stylo\dom\base\nsdocument.cpp:7954)
#24: nsComputedDOMStyle::UpdateCurrentStyleSources (c:\mozilla-source\stylo\layout\style\nscomputeddomstyle.cpp:818)
#25: nsComputedDOMStyle::GetPropertyCSSValue (c:\mozilla-source\stylo\layout\style\nscomputeddomstyle.cpp:976)
#26: nsComputedDOMStyle::GetPropertyValue (c:\mozilla-source\stylo\layout\style\nscomputeddomstyle.cpp:402)
#27: nsComputedDOMStyle::GetPropertyValue (c:\mozilla-source\stylo\layout\style\nscomputeddomstyle.cpp:340)
#28: mozilla::dom::CSS2PropertiesBinding::get_marginLeft (c:\mozilla-source\stylo\obj-firefox-stylo\dom\bindings\css2propertiesbinding.cpp:25460)
#29: mozilla::dom::GenericBindingGetter (c:\mozilla-source\stylo\dom\bindings\bindingutils.cpp:2849)
#30: js::CallJSNative (c:\mozilla-source\stylo\js\src\jscntxtinlines.h:239)
#31: js::InternalCallOrConstruct (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:460)
#32: js::CallGetter (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:638)
#33: CallGetter (c:\mozilla-source\stylo\js\src\vm\nativeobject.cpp:1812)
#34: GetExistingProperty<1> (c:\mozilla-source\stylo\js\src\vm\nativeobject.cpp:1860)
#35: NativeGetPropertyInline<1> (c:\mozilla-source\stylo\js\src\vm\nativeobject.cpp:2089)
#36: js::NativeGetProperty (c:\mozilla-source\stylo\js\src\vm\nativeobject.cpp:2124)
#37: js::GetProperty (c:\mozilla-source\stylo\js\src\vm\nativeobject.h:1498)
#38: JS_ForwardGetPropertyTo (c:\mozilla-source\stylo\js\src\jsapi.cpp:2534)
#39: mozilla::dom::GetPropertyOnPrototype (c:\mozilla-source\stylo\dom\bindings\bindingutils.cpp:2036)
#40: mozilla::dom::CSS2PropertiesBinding::DOMProxyHandler::get (c:\mozilla-source\stylo\obj-firefox-stylo\dom\bindings\css2propertiesbinding.cpp:65551)
#41: js::Proxy::get (c:\mozilla-source\stylo\js\src\proxy\proxy.cpp:311)
#42: js::GetProperty (c:\mozilla-source\stylo\js\src\vm\nativeobject.h:1498)
#43: js::GetProperty (c:\mozilla-source\stylo\js\src\jsobj.h:844)
#44: js::GetProperty (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:4311)
#45: GetPropertyOperation (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:192)
#46: Interpret (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:2674)
#47: js::RunScript (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:406)
#48: js::ExecuteKernel (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:690)
#49: js::Execute (c:\mozilla-source\stylo\js\src\vm\interpreter.cpp:719)
#50: Evaluate (c:\mozilla-source\stylo\js\src\jsapi.cpp:4503)
#51: Evaluate (c:\mozilla-source\stylo\js\src\jsapi.cpp:4528)
#52: JS::Evaluate (c:\mozilla-source\stylo\js\src\jsapi.cpp:4587)
#53: nsJSUtils::EvaluateString (c:\mozilla-source\stylo\dom\base\nsjsutils.cpp:207)
#54: nsJSUtils::EvaluateString (c:\mozilla-source\stylo\dom\base\nsjsutils.cpp:274)
#55: nsScriptLoader::EvaluateScript (c:\mozilla-source\stylo\dom\base\nsscriptloader.cpp:2210)
#56: nsScriptLoader::ProcessRequest (c:\mozilla-source\stylo\dom\base\nsscriptloader.cpp:1993)
#57: nsScriptLoader::ProcessPendingRequests (c:\mozilla-source\stylo\dom\base\nsscriptloader.cpp:2250)
#58: mozilla::detail::RunnableMethodImpl<nsScriptLoader * __ptr64 const,void (__cdecl nsScriptLoader::*)(void) __ptr64,1,0>::Run (c:\mozilla-source\stylo\obj-firefox-stylo\dist\include\nsthreadutils.h:869)
#59: nsThread::ProcessNextEvent (c:\mozilla-source\stylo\xpcom\threads\nsthread.cpp:1262)
#60: NS_ProcessNextEvent (c:\mozilla-source\stylo\xpcom\threads\nsthreadutils.cpp:389)
#61: mozilla::ipc::MessagePump::Run (c:\mozilla-source\stylo\ipc\glue\messagepump.cpp:96)
#62: MessageLoop::RunHandler (c:\mozilla-source\stylo\ipc\chromium\src\base\message_loop.cc:232)
#63: MessageLoop::Run (c:\mozilla-source\stylo\ipc\chromium\src\base\message_loop.cc:212)
#64: nsBaseAppShell::Run (c:\mozilla-source\stylo\widget\nsbaseappshell.cpp:158)
#65: nsAppShell::Run (c:\mozilla-source\stylo\widget\windows\nsappshell.cpp:264)
#66: nsAppStartup::Run (c:\mozilla-source\stylo\toolkit\components\startup\nsappstartup.cpp:283)
#67: XREMain::XRE_mainRun (c:\mozilla-source\stylo\toolkit\xre\nsapprunner.cpp:4461)
#68: XREMain::XRE_main (c:\mozilla-source\stylo\toolkit\xre\nsapprunner.cpp:4638)
#69: XRE_main (c:\mozilla-source\stylo\toolkit\xre\nsapprunner.cpp:4729)
#70: do_main (c:\mozilla-source\stylo\browser\app\nsbrowserapp.cpp:235)
#71: NS_internal_main (c:\mozilla-source\stylo\browser\app\nsbrowserapp.cpp:307)
#72: wmain (c:\mozilla-source\stylo\toolkit\xre\nswindowswmain.cpp:118)
#73: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
#74: BaseThreadInitThunk[C:\WINDOWS\System32\KERNEL32.DLL +0x8364]
#75: RtlUserThreadStart[C:\WINDOWS\SYSTEM32\ntdll.dll +0x670d1]

	Xidorn Quan [:xidorn] UTC+11 Reporter
	Comment 1 • 8 years ago

This is probably a consequence of some animation work landed recently... bholley could you have a look at this?

	Xidorn Quan [:xidorn] UTC+11 Reporter
	Comment 2 • 8 years ago

Also cc hiro and boris as it may be related to animation work.

	Hiroyuki Ikezoe (:hiro)
	Comment 3 • 8 years ago

This assertion will be fixed by bug 1334982.