Closed Bug 1335347 Opened 8 years ago Closed 4 years ago

[e10s] `keyup` event for Alt key is not fired when menubar is activated by the Alt key press

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Version:
51 Branch
Platform:
x86_64
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: mz, Assigned: masayuki)

References

(Regressed 1 open bug)

Details

(Keywords: testcase)

Attachments

(2 files)

aa.html
(deleted), text/html
Details
Bug 1335347 - Make `nsMenuBarListener::KeyUp` wait replay event if a content process has focus r=smaug
(deleted), text/x-phabricator-request
Details
Attached file aa.html (deleted) —
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce: Press Alt Press 1 Release 1 Release Alt Attached is a simple onkeydown onkeyup logger. I can reproduce consistently on 51.0.1 on Windows 32-bit. The problem didn't occur (as far as there were no user reports) pre 51. The problem doesn't occur on 51.0.1 on Linux 64-bit. Actual results: KeyDown Alt KeyDown 1 KeyUp 1 Expected results: KeyDown Alt KeyDown 1 KeyUp 1 JeyUp Alt
Has STR: --- → yes
Component: Untriaged → Event Handling
Keywords: testcase
OS: Unspecified → Windows 10
Product: Firefox → Core
Hardware: Unspecified → x86_64
I think it's buggy only with e10s enabled. non-e10s result: keydown Alt { target: body, key: "Alt", charCode: 0, keyCode: 18 } keydown Alt { target: body, key: "1", charCode: 0, keyCode: 49 } keyup Alt { target: body, key: "1", charCode: 0, keyCode: 49 } keyup { target: body, key: "Alt", charCode: 0, keyCode: 18 } e10s result: keydown Alt { target: body, key: "Alt", charCode: 0, keyCode: 18 } keydown Alt { target: body, key: "1", charCode: 0, keyCode: 49 } keyup Alt { target: body, key: "1", charCode: 0, keyCode: 49 }
FF49 with e10s has the bug too.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Alt not firing keyup event if another key is pressed after keydown [Windows] → [e10s] Alt not firing keyup event if another key is pressed after keydown [Windows]
Hi Stone, could you help take a look at this one? Thanks!
Flags: needinfo?(sshih)
Priority: -- → P2
Priority: P2 → P3
Any progress? This (and bug 1435717) makes Firefox pretty much unusable with noVNC as it wedges the Alt key in the remote session.
Any possible workarounds for us writing web apps until this is fixed?
This is my plan at the moment: https://github.com/novnc/noVNC/pull/1036 However it doesn't prevent the menu from popping up when Alt is pressed and released by itself. And it has a delay of course in detecting that Alt has been released.
Is there any progress on this? Any target version for this to be solved? I reported this on v58 and now I'm in v61 (https://bugzilla.mozilla.org/show_bug.cgi?id=1445724)
I suspect this got fixed when bug 1435717 got fixed? So v63 would see the fix.
I can confirm that this works in the nightly build, so I guess this bug should be closed with 63 as the target?
That's good news!! Thank you Pierre
Component: Event Handling → User events and focus handling
Summary: [e10s] Alt not firing keyup event if another key is pressed after keydown [Windows] → [e10s] `keyup` event for Alt key is not fired when memubar is activated by the Alt key press
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

keyup event of Alt key should be fired in content process even if it'll
activate the menubar, and it should be cancelable as same as before enabling
e10s.

Unfortunately, the new test couldn't be written simpler than what it is in
this patch. When I write it with ContentTask.spawn with
ContentTaskUtils.waitForEvent, it sometimes couldn't receive keyup event
in the content process. Therefore, for avoiding intermittent timeout caused
by it, the test in this patch retries 5 times if Alt key events are not
fired in the content process.

Priority: P3 → P2
Summary: [e10s] `keyup` event for Alt key is not fired when memubar is activated by the Alt key press → [e10s] `keyup` event for Alt key is not fired when menubar is activated by the Alt key press

smaug: ping for review. I guess it's dropped from your queue accidentally.

Flags: needinfo?(bugs)

It is still there in the queue :)
Review queue was just rather long after my vacation. Sorry about the delay.

Flags: needinfo?(bugs)
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e176bd45edd8 Make `nsMenuBarListener::KeyUp` wait replay event if a content process has focus r=smaug

https://hg.mozilla.org/mozilla-central/rev/e176bd45edd8

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Nu sure if exists but just a idea is if possible an option in about:config to disable the menu who not what it ?

(In reply to Andronachi Marian from comment #20)

Nu sure if exists but just a idea is if possible an option in about:config to disable the menu who not what it ?

"ui.key.menuAccessKeyFocuses"

Regressions: 1678216

Backed out for causing failures in browser_alt_keyup_in_content.js

backout: https://hg.mozilla.org/mozilla-central/rev/6bf980923afe9a1c1f26929b4b188558be85b114

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=e176bd45edd8b076190a341010aca3224cd47cd0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

failure log: https://treeherder.mozilla.org/logviewer?job_id=322249074&repo=autoland&lineNumber=5156

[task 2020-11-19T01:12:22.258Z] 01:12:22 INFO - TEST-PASS | dom/events/test/browser_alt_keyup_in_content.js | Testing menubar is shown by Alt keyup: Menubar should've been activated by the synthesized Alt key press -
[task 2020-11-19T01:12:22.258Z] 01:12:22 INFO - Buffered messages logged at 01:12:17
[task 2020-11-19T01:12:22.258Z] 01:12:22 INFO - Testing menubar is shown by Alt keyup: Inactivating the menubar...
[task 2020-11-19T01:12:22.258Z] 01:12:22 INFO - Buffered messages finished
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - TEST-UNEXPECTED-FAIL | dom/events/test/browser_alt_keyup_in_content.js | Aborting this test due to unexpected the exception (Testing menubar is shown by Alt keyup: Waiting for closing all popups - timed out after 50 tries.) -
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - Stack trace:
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - chrome://mochitests/content/browser/dom/events/test/browser_alt_keyup_in_content.js:runTests:271
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - Leaving test bound runTests
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - GECKO(9692) | MEMORY STAT | vsize 2104241MB | vsizeMaxContiguous 67431177MB | residentFast 243MB | heapAllocated 76MB
[task 2020-11-19T01:12:22.259Z] 01:12:22 INFO - TEST-OK | dom/events/test/browser_alt_keyup_in_content.js | took 5779ms

Status: RESOLVED → REOPENED
status-firefox85: fixed → ---
Flags: needinfo?(masayuki)
Resolution: FIXED → ---
Target Milestone: 85 Branch → ---
Attachment #9185920 - Attachment description: Bug 1335347 - Make `nsMenuBarListener::KeyUp` wait replay event if a content process has focus r=smaug! → Bug 1335347 - Make `nsMenuBarListener::KeyUp` wait replay event if a content process has focus r=smaug
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/5b8265dc60c8 Make `nsMenuBarListener::KeyUp` wait replay event if a content process has focus r=smaug

Sigh. browser-chrome framework is really buggy according to the log.

[task 2020-11-19T01:12:16.471Z] 01:12:16     INFO - TEST-START | dom/events/test/browser_alt_keyup_in_content.js
[task 2020-11-19T01:12:22.193Z] 01:12:22     INFO - TEST-INFO | started process screenshot
[task 2020-11-19T01:12:22.255Z] 01:12:22     INFO - TEST-INFO | screenshot: exit 0
[task 2020-11-19T01:12:22.255Z] 01:12:22     INFO - Buffered messages logged at 01:12:16
[task 2020-11-19T01:12:22.255Z] 01:12:22     INFO - Entering test bound runTests
[task 2020-11-19T01:12:22.256Z] 01:12:22     INFO - TEST-PASS | dom/events/test/browser_alt_keyup_in_content.js | This test assumes that Alt key activates the menubar - 
[task 2020-11-19T01:12:22.256Z] 01:12:22     INFO - Start to test: Testing menubar is shown by Alt keyup...
[task 2020-11-19T01:12:22.256Z] 01:12:22     INFO - Testing menubar is shown by Alt keyup: Waiting browser getting focus...
[task 2020-11-19T01:12:22.257Z] 01:12:22     INFO - Testing menubar is shown by Alt keyup: Waiting content process getting focus...
[task 2020-11-19T01:12:22.257Z] 01:12:22     INFO - Testing menubar is shown by Alt keyup: Waiting keyup events of Alt in chrome...
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1210}]
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - Testing menubar is shown by Alt keyup: Waiting keyup event in content...
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - A popup is hidden (visible popups: -1)
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - TEST-PASS | dom/events/test/browser_alt_keyup_in_content.js | Testing menubar is shown by Alt keyup: Menubar should've been activated by the synthesized Alt key press - 
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - Buffered messages logged at 01:12:17
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - Testing menubar is shown by Alt keyup: Inactivating the menubar...
[task 2020-11-19T01:12:22.258Z] 01:12:22     INFO - Buffered messages finished
[task 2020-11-19T01:12:22.259Z] 01:12:22     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/browser_alt_keyup_in_content.js | Aborting this test due to unexpected the exception (Testing menubar is shown by Alt keyup: Waiting for closing all popups - timed out after 50 tries.) - 
[task 2020-11-19T01:12:22.259Z] 01:12:22     INFO - Stack trace:
[task 2020-11-19T01:12:22.259Z] 01:12:22     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-19T01:12:22.259Z] 01:12:22     INFO - chrome://mochitests/content/browser/dom/events/test/browser_alt_keyup_in_content.js:runTests:271

[task 2020-11-19T01:12:22.258Z] 01:12:22 INFO - A popup is hidden (visible popups: -1)

This means that a popup was open at starting the test, i.e., previously running test nor the framework didn't clean up the previous test's popup. That may cause intermittent failure of the new test anyway. I'll modify it to ignore unexpected popup hidden events for avoiding the timeout, but another intermittent failure could happen.

Flags: needinfo?(masayuki)

https://hg.mozilla.org/mozilla-central/rev/5b8265dc60c8

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: