Closed Bug 1335618 Opened 8 years ago Closed 5 years ago

CSP regression: BugzillaJS inline treeherder results are broken

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Product:
bugzilla.mozilla.org
Component:
User Interface
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: mrbkap, Unassigned)

References

Details

(Whiteboard: [october-2019-bmo-triage] )

One feature provided by the BugzillaJS extension [1] is to add inline treeherder results in bugs. This is done by inserting an iframe in comments with links to treeherder with a specially crafted URL [2] that gives a summary of the results. With the new CSP, the iframe doesn't load. For some reason I don't get an error in my JS console about this -- I wonder if that's because the iframe is added dynamically. Would it be possible to get an exception to the CSP or to find a better way to implement this? Thanks. [1] https://addons.mozilla.org/en-US/firefox/addon/bugzillajs/ [2] https://treeherder.mozilla.org/embed/resultset-status/<tree>/<rev>
Severity: major → normal
a better way to implement this would be a patch that adds it to the bug modal view. I will look at the code in a little bit and update this bug with my recommendation.
Have we decided if we're adding Treeherder as an extension?
Flags: needinfo?(dylan)
That would be the best option. ashughes was able to get socorro lens in pretty easily so there is precedent.
Flags: needinfo?(dylan)
Component: User Interface: Modal → User Interface

Karl, is this still needed?

Flags: needinfo?(kthiessen)
Whiteboard: [october-2019-bmo-triage]

I don't know, to be honest. I'll run it by the team tomorrow. Adding Treeherder as an extension is not on our roadmap at all; I'm not even sure what would be involved.

Leaving ni? here to remind myself to come back after I've talked with the team tomorrow.

Our team is not working on the BugzillaJS extension, and has no outstanding needs for CSP changes from BMO.

MattN is one of the current listed authors for the BugzillaJS extension. NI'ing him to see whether the latest version of the extension needs the CSP change.

Flags: needinfo?(kthiessen) → needinfo?(MattN+bmo)

The TreeHerder feature of bugzillajs didn't get ported to the web extension version because of this bug. If this bug was fixed then it could easily be re-added as the code still exists: https://github.com/gkoberger/BugzillaJS/blob/master/legacy/bugzilla-treeherder.js

Flags: needinfo?(MattN+bmo)

(In reply to Blake Kaplan (:mrbkap) (inactive, use needinfo) from comment #0)

[2] https://treeherder.mozilla.org/embed/resultset-status/<tree>/<rev>

This links seems to no longer work. Is there an updated link we can use?

Flags: needinfo?(MattN+bmo)

Because of this bug there was no usage for that endpoint and therefore it was removed in bug 1433104.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(MattN+bmo)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.