Closed
Bug 1335655
Opened 8 years ago
Closed 8 years ago
Rename aboutTelemetry.fetchSymbols and aboutTelemetry.hideSymbols to reflect new string content
Categories
(Toolkit :: Telemetry, defect, P2)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: flod, Assigned: yarik.sheptykin)
References
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
https://hg.mozilla.org/mozilla-central/diff/1789e79681dd/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
2 strings were changed without a new ID
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Tentatively assigning to the same assignee as bug 1299773
|
||
Updated•8 years ago
|
Priority: -- → P2
Whiteboard: [measurement:client]
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833302 [details]
Bug 1335655: Renamed locale ids to reflect content change.
https://reviewboard.mozilla.org/r/109560/#review110598
Looks good, but fix the typo in the commit message (reflec). Suggested commit message: "Bug 1335655: Renamed string IDs to reflect content change"
Attachment #8833302 -
Flags: review?(francesco.lodolo) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8833302 [details]
Bug 1335655: Renamed locale ids to reflect content change.
https://reviewboard.mozilla.org/r/109560/#review110598
Thanks! Fixed!
|
|
Assignee | |
Comment 5•8 years ago
|
||
Georg, do you want to take a look? Or land?
Flags: needinfo?(gfritzsche)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833302 [details]
Bug 1335655: Renamed locale ids to reflect content change.
https://reviewboard.mozilla.org/r/109560/#review110858
Attachment #8833302 -
Flags: review+
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/0c92f27724ae
Renamed locale ids to reflect content change. r=flod,gfritzsche
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•