Paul Silaghi, QA [:pauly] Reporter
	Description • 8 years ago

[Affected versions]:
- 54

[Affected platforms]:
- all

[Steps to reproduce]:
1. Open https://mozilla.github.io/webrtc-landing/gum_test.html
2. Click the "Screen" button
3. From the dropdown select screen to preview
4. Click once the "screen share" permission in the location bar

[Expected result]:
- No change

[Actual result]:
- 'No screen' shows preview of the active screen

[Regression range]:
- tbd

[Additional notes]:
- Screencast: https://www.screencast.com/t/tXW6CuYWQI6G

	Florian Quèze [:florian] Assignee
	Comment 1 • 8 years ago

Seems like an edge case of bug 1325223 that I didn't cover there.

	Florian Quèze [:florian] Assignee
	Comment 3 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa44bf9c62e9

	Johann Hofmann [:johannh]
	Comment 4 • 8 years ago

Comment on attachment 8836090 [details] [diff] [review]
Patch

Review of attachment 8836090 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't tried the patch locally but this looks pretty straightforward and has a test, so r=me

::: browser/base/content/test/popupNotifications/browser_popupNotification_5.js
@@ +330,5 @@
>        this.notification2.remove();
>        this.notification3.remove();
>      }
>    },
> +  // Test clicking the anchor icon.

Maybe you should mention the purpose of this test. :)

	Florian Quèze [:florian] Assignee
	Comment 5 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbcec3916fc695fa52d0dab1a3e459cf46144a1e
Bug 1336066 - avoid reshowing a persistent notification that has not been dismissed when clicking the anchor icon, r=johannh.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/bbcec3916fc6

	Hani Yacoub, Desktop QA
	Comment 7 • 8 years ago

Build ID: 20170214030231
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

Verified as fixed on on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1, Firefox Nightly 53.0a1 and Aurora 53.0a2.

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 8 years ago

Hani, how was this verified on 53 when this hasn't been uplifted to Aurora yet?

That said, please request Aurora approval on this, Florian :)

	Hani Yacoub, Desktop QA
	Comment 9 • 8 years ago

Sorry about that, I messed up the comments with another bug that I verified on Aurora too.


I Verified this bug on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1, as the flags indicates the version of Firefox which I tested.

Thanks.

	Florian Quèze [:florian] Assignee
	Comment 10 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=417b1f06fda1

	Florian Quèze [:florian] Assignee
	Comment 11 • 8 years ago

Comment on attachment 8836090 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1004061
[User impact if declined]: possibly confusing state of permission prompt panels (and especially the screen sharing one with a preview) after clicking the anchor icon. Potential for leaking a video stream if there was an active screensharing preview at the time the anchor icon was clicked.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Not required but would be nice, steps are in comment 0.
[List of other uplifts needed for the feature/fix]: none.
[Is the change risky?]: Low.
[Why is the change risky/not risky?]: One-line code change, and covered by automated test, which seem green on the try push from comment 10.
[String changes made/needed]: none.

	Gerry Chang [:gchang]
	Comment 12 • 8 years ago

Comment on attachment 8836090 [details] [diff] [review]
Patch

Fix a screensharing regression and was verified. Aurora53+.

	Ryan VanderMeulen [:RyanVM]
	Comment 13 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce2403f3f23b

	Hani Yacoub, Desktop QA
	Comment 14 • 8 years ago

Build ID: 20170221004019
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

Verified as fixed on Aurora 53.0a2 (20170221004019) on Windows 10 x 64, Mac OS X 10.10 and Ubuntu 16.04 x64.