28:54.07 INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o") 28:54.07 28:54.07 ../../gfx/thebes/Unified_cpp_gfx_thebes0.o: In function `ZN7mozilla3gfx15DeviceManagerDx20InitializeDirectDrawEv': 28:54.07 /home/worker/workspace/mingw-w64-build/firefox/gfx/thebes/DeviceManagerDx.cpp:856: undefined reference to `IID_IDirectDraw7' 28:54.07 collect2: error: ld returned 1 exit status

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=abb3399386b70d90288a3bbe6e81e78398ab4493

Comment on attachment 8833436 [details] Bug 1336542 Include dxguid in the linked libraries https://reviewboard.mozilla.org/r/109670/#review111942

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/50bfba6371da Include dxguid in the linked libraries r=jimm

Comment on attachment 8833436 [details] Bug 1336542 Include dxguid in the linked libraries Approval Request Comment [Feature/Bug causing the regression]: mingw build failure in ESR52. [User impact if declined]: Tor will need to carry another custom patch. [Is this code covered by automated tests?]: I believe so. If the browser works at all, it should work, I think. [Has the fix been verified in Nightly?]: I don't know. (I'm not sure how to tell if a commit has made its way into Nightly or not...) [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: It seems slightly risky? [Why is the change risky/not risky?]: The change affects all Windows builds, as opposed to just mingw builds. But on the flip side, it's an additional linked library which seems like it should not cause problems? [String changes made/needed]: None

Comment on attachment 8833436 [details] Bug 1336542 Include dxguid in the linked libraries mingw link fix, aurora53+, beta52+

Setting qe-verify- per comment 6.