Closed
Bug 1336563
Opened 8 years ago
Closed 8 years ago
Clean up accidental Pulsebot spam from Servo vendoring
Categories
(bugzilla.mozilla.org :: Administration, task)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gps, Assigned: dylan)
References
Details
Attachments
(2 files)
(deleted),
text/csv
|
Details | |
(deleted),
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
I recently pushed Servo to integration/autoland.
pulsebot interpreted GitHub Pull Request numbers in commit messages as bugs and started spamming lots of 5 digit bugs with push information. e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=10470#c22. So far, the highest bug number it will have tried posting to is 15355.
Is there any way we can clean up these comments?
Reporter | ||
Comment 1•8 years ago
|
||
emceeaich disabled pulsebot's BMO account a few minutes ago. It is probably safe to say that any posts from that account between 2017-02-03 19:58:07Z and now are safe to delete/prune/hide/whatever.
Comment 2•8 years ago
|
||
See also: https://github.com/glandium/pulsebot/issues/13 (Better handling of servo commits).
Comment 3•8 years ago
|
||
This is list of comments made by pulsebot during the time in question:
select bug_id, comment_id from longdescs where who = (select userid from profiles where login_name = 'pulsebot@bots.tld') and bug_id REGEXP '^[0-9]{5}$' and bug_id < 15356
We could just delete the comments if necessary or set a hidden tag on them if we do not want to delete.
dkl
Comment 4•8 years ago
|
||
(In reply to David Lawrence [:dkl] from comment #3)
None of those bug IDs look like they would have contained useful comments. I'd vote for nuking them all.
Reporter | ||
Comment 5•8 years ago
|
||
I concur with RyanVM that those bug numbers almost certainly aren't relevant and can be nuked. If you wanted, you could also do a content-based check. If the comment has "gszorc@mozilla.com" in it, it can be deleted, as I didn't touch any bugs in this range.
Updated•8 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Comment 6•8 years ago
|
||
would like a quick sanity check on this before i run it on the admin node.
This is the SQL I used to generate the csv output:
select bug_id, comment_id from longdescs where who = (select userid from profiles where login_name = 'pulsebot@bots.tld') and bug_id REGEXP '^[0-9]{5}$' and bug_id < 15356 and thetext like '%gszorc@mozilla.com%'
thanks
dkl
Attachment #8835009 -
Flags: review?(dylan)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8835009 [details] [diff] [review]
1336563_1.patch
Review of attachment 8835009 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm, I verified that remove_from_db() handles longdescs_activity and longdescs_tags
Attachment #8835009 -
Flags: review?(dylan) → review+
Comment 8•8 years ago
|
||
To https://github.com/mozilla-bteam/bmo.git
ab5eef9..730ca12 master -> master
Script committed. Will close bug once the comments have been removed.
Flags: needinfo?(dkl)
Comment 9•8 years ago
|
||
Comments have been deleted. Closing.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dkl)
Resolution: --- → FIXED
Comment 10•8 years ago
|
||
I happen to have triggered another bunch of comments from running a replay script from the wrong branch of pulsebot, which didn't have the changes to handle servo.
The damage is less severe this time, and I have the full list of six bugs where pulsebot commented, but tagging them didn't work.
The bugs are: 16174, 16160, 16155, 16164, 16168 and 16098.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•8 years ago
|
||
So I just need to re-run the script on those bugs?
:dkl?
Assignee: dkl → dylan
Flags: needinfo?(dylan)
Comment 12•8 years ago
|
||
(In reply to Dylan Hardison [:dylan] from comment #11)
> So I just need to re-run the script on those bugs?
>
> :dkl?
Yep. I think it was mozilla/bmo/master/scripts/delete_comments_csv.pl
dkl
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(dylan)
Assignee | ||
Comment 13•8 years ago
|
||
Deleting comment '12191455' from bug '16098' ... done.
Deleting comment '12191451' from bug '16155' ... done.
Deleting comment '12191450' from bug '16160' ... done.
Deleting comment '12191452' from bug '16164' ... done.
Deleting comment '12191453' from bug '16168' ... done.
Deleting comment '12191448' from bug '16174' ... done.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•