Closed
Bug 1336581
Opened 8 years ago
Closed 8 years ago
Permafailing Android msk with dom/canvas/test/test_imagebitmap_cropping.html | pixel 0,0 of is 0,61,140,255; expected 255,255,255,255 +/- 5
Categories
(Core :: Graphics: Canvas2D, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | fixed |
firefox54 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: bc)
Details
(Keywords: intermittent-failure, Whiteboard: [gfx-noted][stockwell disabled])
Attachments
(2 files)
(deleted),
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=74283203&repo=mozilla-central https://autophone.s3.amazonaws.com/v1/task/Vl94iZhWQmaVPJtbwNh9JA/runs/0/artifacts/public/build/mochitest-skia-mochitests-skia-settings.ini-1-nexus-6p-9-1318609c-9879-4e4f-b598-f6251dc0396c.log This started failing on this merge to m-c https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=9f17a6fc04f9540ffe11d7ad4e22db5a37df6e23 I don't believe Msk is run on integration branches, so I'm not sure what caused this. Maybe Bug 1332657?
Comment 1•8 years ago
|
||
Bug 1332657 is only for stylo. I don't think the bug affects Android.
No longer depends on: 1332657
Comment 2•8 years ago
|
||
Hello kaku, do you see any suspicious changes in comment 0 that broke the test you wrote?
Flags: needinfo?(kaku)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 4•8 years ago
|
||
This only fails on the Nexus 6P devices. https://en.wikipedia.org/wiki/Nexus_4 1280x768 px https://en.wikipedia.org/wiki/Nexus_5 1920Γ1080 px https://en.wikipedia.org/wiki/Nexus_6P 2560x1440 px https://en.wikipedia.org/wiki/Pixel_(smartphone) 1920 x 1080 This leads me to believe this may be a screen size issue. We also have available Nexus 6 and Nexus 9 devices but don't run the unit tests on them due to load issues. https://en.wikipedia.org/wiki/Nexus_6 2560Γ1440 px https://en.wikipedia.org/wiki/Nexus_9 2048x1536 px I'll do a try run and see if we can reproduce the same pattern on large screens.
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6eaf98ecd9630808c511f802541ab8f00ae2669&exclusion_profile=false shows perma orange on all devices regardless of screen size. I failed to notice that the Msk only runs on the Nexus 6Ps due to the perma failure on the other devices: Bug 1317362 and Bug 1324465. We can turn off Msk for the Nexus 6P devices since I don't believe anyone cares about Msk.
Updated•8 years ago
|
OS: Unspecified → Android
Hardware: Unspecified → ARM
Whiteboard: [gfx-noted]
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Comment 7•8 years ago
|
||
try run with patch from bug 1338256 https://treeherder.mozilla.org/#/jobs?repo=try&revision=65c6e4d05bb71207e3828e1a811a052a5834669f&filter-searchStr=autophone previous try run with failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48d7a0d878e7bb67a722b6593d558ec743f46fc8&filter-searchStr=Msk Probably another won't fix once it is greened up.
Attachment #8835655 -
Flags: review?(gbrown)
![]() |
||
Comment 8•8 years ago
|
||
Comment on attachment 8835655 [details] [diff] [review] bug-1336581-autophone-mochitest-skia.patch Review of attachment 8835655 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: dom/canvas/test/mochitest.ini @@ +227,5 @@ > [test_drawImage_edge_cases.html] > [test_drawWindow.html] > support-files = file_drawWindow_source.html file_drawWindow_common.js > [test_imagebitmap.html] > +skip-if = android_version >= '17' && android_version <= '19' # bug 1336581 All the skip-if's that include android_version == '18' will skip the test on the 4.3 emulator, where AFAIK, they have not been troublesome. I don't think that's a big deal, but it is non-ideal.
Attachment #8835655 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 9•8 years ago
|
||
I could change that to android_version == '17' || android_version == '19' without too much trouble. I'll try that in a bit. Thanks.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bob
Status: NEW → ASSIGNED
Comment 13•8 years ago
|
||
:bc, if this was r+ last week, can we assume it is deployed now?
Flags: needinfo?(bob)
Assignee | ||
Comment 14•8 years ago
|
||
No, not yet. I can do that now. I was hoping to get the Mdm test manifests done and land them both at the same time, but I'll do it right now.
Flags: needinfo?(bob)
Comment 15•8 years ago
|
||
Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/42e0a1f60287 Disable failing Mochitest Skia tests on Android, r=gbrown
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/42e0a1f60287
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•8 years ago
|
Flags: needinfo?(kaku)
Updated•8 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Whiteboard: [gfx-noted] → [gfx-noted][stockwell disabled]
Flags: needinfo?(snorp)
Assignee | ||
Comment 19•8 years ago
|
||
Original patch with updated commit message including a=test-only. carrying forward r+. This applies cleanly to mozilla-release.
Attachment #8856760 -
Flags: review+
Assignee | ||
Comment 20•8 years ago
|
||
requesting uplift to release/53.
Flags: needinfo?(ryanvm)
Whiteboard: [gfx-noted][stockwell disabled] → [gfx-noted][stockwell disabled][checkin-needed-release]
Comment 21•8 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/22c3a05cb4bc56f4fb7fa4e86ee41a7b6ba469fd
Flags: needinfo?(ryanvm)
Whiteboard: [gfx-noted][stockwell disabled][checkin-needed-release] → [gfx-noted][stockwell disabled]
You need to log in
before you can comment on or make changes to this bug.
Description
•