Closed
Bug 1337328
Opened 8 years ago
Closed 8 years ago
Uplift cubeb to revision 927877
Categories
(Core :: Audio/Video: cubeb, defect)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file)
This brings in:
- Drift fix on WASAPI
- Fix default device selection on Pulse
- Test code simplification
- Allow using MOZ_ASSERT inside cubeb
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → padenot
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8834346 [details]
Bug 1337328 - Uplift cubeb to revision 927877.
https://reviewboard.mozilla.org/r/110318/#review111492
Looks good, thanks
Attachment #8834346 -
Flags: review?(achronop) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/6befd9682522
Uplift cubeb to revision 927877. r=achronop
|
|
Assignee | |
Comment 4•8 years ago
|
||
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Comment 8•8 years ago
|
||
By the way, I noticed that this turns XASSERT into a MOZ_ASSERT, where it was previously closer to a MOZ_RELEASE_ASSERT. As a result these assertions will be optimized out on all opt builds. If there are any important assertions that should receive testing outside of automation, it might be worth adding an XRELEASE_ASSERT or something to that effect that maps to MOZ_RELEASE_ASSERT.
|
|
Assignee | |
Comment 9•8 years ago
|
||
Yeah I'll fix that today, good catch.
You need to log in
before you can comment on or make changes to this bug.
Description
•