Closed
Bug 1337510
Opened 8 years ago
Closed 8 years ago
Remove createCommandButtons / toolbarSpec
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(firefox54 verified)
VERIFIED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | verified |
People
(Reporter: jryans, Assigned: ochameau)
References
Details
Attachments
(1 file)
Bug 1320149 reworked the command buttons so that they don't use createCommandButtons / toolbarSpec anymore, but the code is still in place.
Reporter | ||
Comment 1•8 years ago
|
||
:ochameau, should we remove this as well?
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 2•8 years ago
|
||
Yes. I didn't realized createCommandButtons was only used there. There may be even more to be removed?
Assignee: nobody → poirot.alex
Flags: needinfo?(poirot.alex)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8834648 [details] Bug 1337510 - Remove dead code related to gcli command buttons. https://reviewboard.mozilla.org/r/110472/#review111786 Thanks, looks good to me!
Attachment #8834648 -
Flags: review?(jryans) → review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01626a468701 Remove dead code related to gcli command buttons. r=jryans
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/01626a468701
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 7•7 years ago
|
||
I have reproduced this bug on Firefox nightly according to (2017-02-07) Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0 Tested OS-- Windows7 32bit [testday-20170428]
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•