AssignWithConversion is used in nsWindowWatcher.cpp; it should, instead, use NS_ConvertUTF8toUCS2.

-> danm

.

This is causing the "Reset Master Password" functionality to not work in translated versions which translate the InternalToken string in pipnss.properties to a string which contains non-ASCII characters. In mozilla/security/manager/pki/resources/content/pref-masterpass.js, internal_token.tokenName is passed via window.open to mozilla/security/manager/pki/resources/content/resetpassword.js. In resetpassword.js, the tokenName is then passed to findTokenByName. In our internal testing, we found that the tokenName parameter was being corrupted via the AssignWithConversion call in nsWindowWatcher::OpenWindowJS. After changing the usage of AssignWithConversion to NS_ConvertUTF8toUCS2, the problem was fixed. This problem can be reproduced in the French translated version of Netscape 7.

How can we be so sure that aName has to be UTF-8 AssignWithConversion is definitely wrong. But I am not sure treat it as UTF8 is right neither. We should look at the api. Why we use char* here instead of PRUnichar* for aName?

reassign this to simon montagu. Simon. Please work with danm about this issue.

cc. rchen

If you look at the code that calls this function, it shows the UTF8 stuff. Here is the call from nsGlobalWindow: http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsGlobalWindow.cpp#4295 name is explicitly set with ToNewUTF8String The other calls I can find call ww->OpenWindow with "_blank" explicitly as the name

Comment on attachment 101456 [details] [diff] [review] AssignWithConversion -> NS_ConvertUTF8toUCS2 It would have been nicer to change the API to use a Unicode string rather than doing a double conversion, but since the interface is frozen, this seems to be the way to go. r=smontagu

This is a problem too in the JA 11/05 build. I can not use the Reset Password button.

adding nsbeta1+

Any update on this one?

Comment on attachment 101456 [details] [diff] [review] AssignWithConversion -> NS_ConvertUTF8toUCS2 Ok, just make sure this is really UTF8 here! (are you sure it isn't the native charset?)

>just make sure this is really UTF8 here! See comment 8

Checked in: Checking in nsWindowWatcher.cpp; /cvsroot/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,v <-- nsWindowWatcher.cpp new revision: 1.69; previous revision: 1.68 done