Remove support for remote discovery pane in about:addons
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: pauljt, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: triaged)
Attachments
(2 files, 1 obsolete file)
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Comment 7•8 years ago
|
||
Comment 8•8 years ago
|
||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Comment 14•6 years ago
|
||
Can this old patch be dusted off now?
Comment 15•6 years ago
|
||
(In reply to David Durst [:ddurst] from comment #14)
Can this old patch be dusted off now?
Someone can for sure, I have no time to work on this though. I seem to remember that the patch basically worked but was hitting some test failures that I never got around to fixing.
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Comment 16•5 years ago
|
||
This was disabled on 68 in bug 1540173, right? Should we mark this fixed and file a follow-up to rip out the old code from 70 once we merge?
Comment 17•5 years ago
|
||
(In reply to :Gijs (he/him) from comment #16)
This was disabled on 68 in bug 1540173, right? Should we mark this fixed and file a follow-up to rip out the old code from 70 once we merge?
Yes, to be precise the new discovery panel has been enabled by default (along with the HTML about:addons) by Bug 1555012.
Marking this one as fixed sounds reasonable to me too (we will definitely not work on any other fixes, the fix we did choose to apply is the "enabling the new rewritten discovery panel" one, and Bug 1555012 has been already landed in beta).
Currently we have Bug 1558982 for the "Remove XUL about:addons" step, we could use that bugzilla issue to follow-up on it, or file a new one specifically related to ripping off the old discovery panel (and the "about:config" preference that allows a user to switch back to it) and make it a blocker for Bug 1558982.
Updated•5 years ago
|
Comment 18•5 years ago
|
||
This bug can be closed once we stop supporting extensions.htmlaboutaddons.discover.enabled=false
That includes the removal of toolkit/mozapps/extensions/test/browser/browser_discovery.js
The pref is also used in https://searchfox.org/mozilla-central/rev/e62c920f7f6463239c6634113f8a8351e263b936/toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js#165,200 , but its purpose in the test can be fulfilled by using extensions.getAddons.showPane
instead.
Comment 19•5 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #18)
This bug can be closed once we stop supporting extensions.htmlaboutaddons.discover.enabled=false
What's stopping us from doing that?
Comment 20•5 years ago
|
||
(In reply to Andrew Swan [:aswan] from comment #19)
(In reply to Rob Wu [:robwu] from comment #18)
This bug can be closed once we stop supporting extensions.htmlaboutaddons.discover.enabled=false
What's stopping us from doing that?
+ni for this
Comment 21•5 years ago
|
||
The extensions.htmlaboutaddons.discover.enabled
pref is not set in mail/app/profile/all-thunderbird.js, so Thunderbird is still relying on being able to load some remote content.
They can probably restore their requested functionality in comm-central if they really need it. If the code gets removed, ping the people who were involved with bug 1558860.
Comment 22•5 years ago
|
||
(Adjusting summary so that this bug can be used as the parent of bugs related to the remote disco pane)
Comment 23•5 years ago
|
||
Because of the security impact, I'd really like this to go away. What's stopping us from doing that?
Comment 24•5 years ago
|
||
I'd like to remove support for remotely hosted discopane.
It's still in the tree because Thunderbird relies on it. But they're on ESR68, and the next ESR is still a few months away.
I want to remove the code for the remotely hosted discopane soonish.
Does Thunderbird already have a viable replacement for the discover pane in about:addons
in the planning?
Assignee | ||
Comment 25•5 years ago
|
||
I'm starting to look at moving the sidebar into the HTML document which means this would be the only content in the XUL document. Removing it definitely makes more sense than the work it will take to support it. I think it will need to go in 73.
Comment 26•5 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #24)
Does Thunderbird already have a viable replacement for the discover pane in
about:addons
in the planning?
Yep, I filed bug 1600923 to take care of it. Thanks for notifying!
Assignee | ||
Comment 27•5 years ago
|
||
Comment 28•5 years ago
|
||
Comment 29•5 years ago
|
||
bugherder |
Comment 30•5 years ago
|
||
Hello,
Currently the extensions.htmlaboutaddons.discover.enabled is no longer listed by default in about:config in FF Nightly 73.0a1 20191210095443, while before in FF 72 it was enabled and set as True.
Is it correct to interpret that a sanity check for the about:addons page needs to be performed in order to verify this ticket or are there other test areas to check?
Thank you
Assignee | ||
Comment 31•5 years ago
|
||
I don't think this needs any specific QA. This shouldn't have any effect without having made changes to about:config previously and we didn't really support the code that's been removed.
Description
•